This is an automated email from the ASF dual-hosted git repository.
sgilmore pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 493d456d8c GH-41507: [MATLAB][CI] Pass `strict: true` to
`matlab-actions/run-tests@v2` (#41530)
493d456d8c is described below
commit 493d456d8c6eff21659dc87a2dee32abd0be5ffd
Author: Sarah Gilmore <[email protected]>
AuthorDate: Fri May 3 14:43:51 2024 -0400
GH-41507: [MATLAB][CI] Pass `strict: true` to `matlab-actions/run-tests@v2`
(#41530)
### Rationale for this change
The MATLAB CI jobs should fail if any one of the unit tests issues a
`warning`. Currently, the MATLAB CI jobs only fail if there is a verification
failure. Passing the argument `strict: true` to `matlab-actions/run-tests@ v2`
will ensure MATLAB jobs will fail if a test warning is issued.
See the [`matlab-actions/run-tests@ v2`
documentation](https://github.com/matlab-actions/run-tests/?tab=readme-ov-file#run-matlab-tests)
for more details.
### What changes are included in this PR?
1. Pass `strict: true` argument to `matlab-actions/setup-matlab@ v2`
### Are these changes tested?
N/A (relying on existing tests).
### Are there any user-facing changes?
No.
* GitHub Issue: #41507
Authored-by: Sarah Gilmore <[email protected]>
Signed-off-by: Sarah Gilmore <[email protected]>
---
.github/workflows/matlab.yml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/matlab.yml b/.github/workflows/matlab.yml
index 8a0de8a365..2ae33d1e8d 100644
--- a/.github/workflows/matlab.yml
+++ b/.github/workflows/matlab.yml
@@ -96,6 +96,7 @@ jobs:
uses: matlab-actions/run-tests@v2
with:
select-by-folder: matlab/test
+ strict: true
macos:
name: AMD64 macOS 12 MATLAB
runs-on: macos-12
@@ -135,7 +136,8 @@ jobs:
MATLABPATH: matlab/install/arrow_matlab
uses: matlab-actions/run-tests@v2
with:
- select-by-folder: matlab/test
+ select-by-folder: matlab/test
+ strict: true
windows:
name: AMD64 Windows 2022 MATLAB
runs-on: windows-2022
@@ -181,4 +183,5 @@ jobs:
MATLABPATH: matlab/install/arrow_matlab
uses: matlab-actions/run-tests@v2
with:
- select-by-folder: matlab/test
+ select-by-folder: matlab/test
+ strict: true
