This is an automated email from the ASF dual-hosted git repository.
tustvold pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/master by this push:
new 0d0c02e71e6 Tweak Private Sbbf::new_with_ndv_fpp Documentation (#5718)
0d0c02e71e6 is described below
commit 0d0c02e71e62f79c0c4012451247849b631d15a4
Author: Yichi Zhang <[email protected]>
AuthorDate: Sun May 5 03:54:28 2024 +0800
Tweak Private Sbbf::new_with_ndv_fpp Documentation (#5718)
* Solve Inconsistency
* Solve inconsistency
* Solve inconsistency
---
parquet/src/bloom_filter/mod.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/parquet/src/bloom_filter/mod.rs b/parquet/src/bloom_filter/mod.rs
index ebdb3999424..f746d8b9a8d 100644
--- a/parquet/src/bloom_filter/mod.rs
+++ b/parquet/src/bloom_filter/mod.rs
@@ -233,7 +233,7 @@ fn num_of_bits_from_ndv_fpp(ndv: u64, fpp: f64) -> usize {
impl Sbbf {
/// Create a new [Sbbf] with given number of distinct values and false
positive probability.
- /// Will panic if `fpp` is greater than 1.0 or less than 0.0.
+ /// Will return an error if `fpp` is greater than or equal to 1.0 or less
than 0.0.
pub(crate) fn new_with_ndv_fpp(ndv: u64, fpp: f64) -> Result<Self,
ParquetError> {
if !(0.0..1.0).contains(&fpp) {
return Err(ParquetError::General(format!(
