This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/main by this push:
new 4f1f6e57c5 Update MSRVs to be accurate (#6742)
4f1f6e57c5 is described below
commit 4f1f6e57c568fae8233ab9da7d7c7acdaea4112a
Author: June <[email protected]>
AuthorDate: Mon Jan 6 14:13:56 2025 -0700
Update MSRVs to be accurate (#6742)
* Update most MSRVs
* Make cargo-msrv verify every package in repo instead of just a select few
and purposefully break arrow-flight msrv
* Add test to ensure workspace rust version is being used at least somewhere
* Fix exit1 => exit 1
* Make arrow-flight work, at the very least, with 'cargo metadata'
* Fix arrow-flight/gen rust-version to make CI pass now
* Get rid of pretty msrv logging as it can't all be displayed
* Do '-mindepth 2' with find to prevent running cargo msrv on the workspace
as a whole
* Use correct MSRV for object_store
* remove workspace msrv check
* revert msrv
* push object_store MSRV back down to 1.62.1
* Revert unrelated formatting changes
* Fix object_store msrv
---------
Co-authored-by: Andrew Lamb <[email protected]>
Co-authored-by: Jeffrey Vo <[email protected]>
---
.github/workflows/rust.yml | 28 +++++++---------------------
Cargo.toml | 2 +-
arrow-flight/gen/Cargo.toml | 2 +-
arrow-integration-testing/Cargo.toml | 2 +-
arrow-pyarrow-integration-testing/Cargo.toml | 2 +-
arrow-schema/Cargo.toml | 2 +-
arrow/Cargo.toml | 2 +-
parquet/Cargo.toml | 2 +-
8 files changed, 14 insertions(+), 28 deletions(-)
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 044250b704..ca0d2441ce 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -123,23 +123,6 @@ jobs:
uses: ./.github/actions/setup-builder
- name: Install cargo-msrv
run: cargo install cargo-msrv
- - name: Downgrade arrow dependencies
- run: cargo update -p ahash --precise 0.8.7
- - name: Check arrow
- working-directory: arrow
- run: |
- # run `cd arrow; cargo msrv verify` to see problematic dependencies
- cargo msrv verify --output-format=json
- - name: Check parquet
- working-directory: parquet
- run: |
- # run `cd parquet; cargo msrv verify` to see problematic dependencies
- cargo msrv verify --output-format=json
- - name: Check arrow-flight
- working-directory: arrow-flight
- run: |
- # run `cd arrow-flight; cargo msrv verify` to see problematic
dependencies
- cargo msrv verify --output-format=json
- name: Downgrade object_store dependencies
working-directory: object_store
# Necessary because tokio 1.30.0 updates MSRV to 1.63
@@ -147,8 +130,11 @@ jobs:
run: |
cargo update -p tokio --precise 1.29.1
cargo update -p url --precise 2.5.0
- - name: Check object_store
- working-directory: object_store
+ - name: Check all packages
run: |
- # run `cd object_store; cargo msrv verify` to see problematic
dependencies
- cargo msrv verify --output-format=json
+ # run `cargo msrv verify --manifest-path "path/to/Cargo.toml"` to
see problematic dependencies
+ find . -mindepth 2 -name Cargo.toml | while read -r dir
+ do
+ echo "Checking package '$dir'"
+ cargo msrv verify --manifest-path "$dir" --output-format=json ||
exit 1
+ done
diff --git a/Cargo.toml b/Cargo.toml
index 75ba410f12..39e3c0bca9 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -74,7 +74,7 @@ include = [
"Cargo.toml",
]
edition = "2021"
-rust-version = "1.62"
+rust-version = "1.70"
[workspace.dependencies]
arrow = { version = "54.0.0", path = "./arrow", default-features = false }
diff --git a/arrow-flight/gen/Cargo.toml b/arrow-flight/gen/Cargo.toml
index 6358227a89..e52efbf67e 100644
--- a/arrow-flight/gen/Cargo.toml
+++ b/arrow-flight/gen/Cargo.toml
@@ -20,7 +20,7 @@ name = "gen"
description = "Code generation for arrow-flight"
version = "0.1.0"
edition = { workspace = true }
-rust-version = { workspace = true }
+rust-version = "1.71.1"
authors = { workspace = true }
homepage = { workspace = true }
repository = { workspace = true }
diff --git a/arrow-integration-testing/Cargo.toml
b/arrow-integration-testing/Cargo.toml
index 8654b4b927..26cb05fae1 100644
--- a/arrow-integration-testing/Cargo.toml
+++ b/arrow-integration-testing/Cargo.toml
@@ -25,7 +25,7 @@ authors = { workspace = true }
license = { workspace = true }
edition = { workspace = true }
publish = false
-rust-version = { workspace = true }
+rust-version = "1.75.0"
[lib]
crate-type = ["lib", "cdylib"]
diff --git a/arrow-pyarrow-integration-testing/Cargo.toml
b/arrow-pyarrow-integration-testing/Cargo.toml
index 03d08df309..4ead95fcb9 100644
--- a/arrow-pyarrow-integration-testing/Cargo.toml
+++ b/arrow-pyarrow-integration-testing/Cargo.toml
@@ -25,7 +25,7 @@ authors = ["Apache Arrow <[email protected]>"]
license = "Apache-2.0"
keywords = [ "arrow" ]
edition = "2021"
-rust-version = "1.62"
+rust-version = "1.70"
publish = false
[lib]
diff --git a/arrow-schema/Cargo.toml b/arrow-schema/Cargo.toml
index 1e1f9fbde0..d1bcf046b7 100644
--- a/arrow-schema/Cargo.toml
+++ b/arrow-schema/Cargo.toml
@@ -26,7 +26,7 @@ license = { workspace = true }
keywords = { workspace = true }
include = { workspace = true }
edition = { workspace = true }
-rust-version = { workspace = true }
+rust-version = "1.64"
[lib]
name = "arrow_schema"
diff --git a/arrow/Cargo.toml b/arrow/Cargo.toml
index 8860cd61c5..a1c9c0ab21 100644
--- a/arrow/Cargo.toml
+++ b/arrow/Cargo.toml
@@ -31,7 +31,7 @@ include = [
"Cargo.toml",
]
edition = { workspace = true }
-rust-version = "1.70.0"
+rust-version = { workspace = true }
[lib]
name = "arrow"
diff --git a/parquet/Cargo.toml b/parquet/Cargo.toml
index 19f8907107..e4085472ea 100644
--- a/parquet/Cargo.toml
+++ b/parquet/Cargo.toml
@@ -26,7 +26,7 @@ authors = { workspace = true }
keywords = ["arrow", "parquet", "hadoop"]
readme = "README.md"
edition = { workspace = true }
-rust-version = "1.70.0"
+rust-version = { workspace = true }
[target.'cfg(target_arch = "wasm32")'.dependencies]
ahash = { version = "0.8", default-features = false, features =
["compile-time-rng"] }
