(arrow-nanoarrow) branch main updated: chore(dev/benchmarks): Update benchmarks build for latest CMake changes (#730)

[paleolimbot]

This is an automated email from the ASF dual-hosted git repository.

paleolimbot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-nanoarrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 1640245b chore(dev/benchmarks): Update benchmarks build for latest 
CMake changes (#730)
1640245b is described below

commit 1640245b762a1ac4f166d95c263447a6f1c9987b
Author: Dewey Dunnington <de...@dunnington.ca>
AuthorDate: Sat Mar 22 14:15:56 2025 -0500

    chore(dev/benchmarks): Update benchmarks build for latest CMake changes 
(#730)
    
    After #719, `target_link_libraries(... nanoarrow)` must be
    `target_link_libraries(... nanoarrow::nanoarrow)` and I'd forgotten to
    update the benchmarks build.
---
 dev/benchmarks/CMakeLists.txt | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/dev/benchmarks/CMakeLists.txt b/dev/benchmarks/CMakeLists.txt
index 25955b0a..48a0e082 100644
--- a/dev/benchmarks/CMakeLists.txt
+++ b/dev/benchmarks/CMakeLists.txt
@@ -71,8 +71,19 @@ elseif(NOT "${NANOARROW_BENCHMARK_SOURCE_URL}" STREQUAL "")
   endif()
 endif()
 
+# nanoarrow >= 0.7 uses an alias target (or explicit _static/_shared)
+if(NOT TARGET nanoarrow::nanoarrow)
+  message(STATUS "Adding nanoarrow::nanoarrow alias target")
+  add_library(nanoarrow::nanoarrow ALIAS nanoarrow)
+endif()
+
+if(NOT TARGET nanoarrow::nanoarrow_ipc)
+  message(STATUS "Adding nanoarrow::nanoarrow_ipc alias target")
+  add_library(nanoarrow::nanoarrow_ipc ALIAS nanoarrow_ipc)
+endif()
+
 # Check that either the parent scope or this CMakeLists.txt defines a 
nanoarrow target
-if(NOT TARGET nanoarrow OR NOT TARGET nanoarrow_ipc)
+if(NOT TARGET nanoarrow::nanoarrow OR NOT TARGET nanoarrow::nanoarrow_ipc)
   message(FATAL_ERROR "nanoarrow or nanoarrow_ipc target not found (missing 
-DNANOARROW_BENCHMARK_SOURCE_URL option?)"
   )
 endif()
@@ -92,8 +103,9 @@ enable_testing()
 
 foreach(ITEM schema;array;ipc)
   add_executable(${ITEM}_benchmark "c/${ITEM}_benchmark.cc")
-  target_link_libraries(${ITEM}_benchmark PRIVATE nanoarrow nanoarrow_ipc
-                                                  benchmark::benchmark_main)
+  target_link_libraries(${ITEM}_benchmark
+                        PRIVATE nanoarrow::nanoarrow nanoarrow::nanoarrow_ipc
+                                benchmark::benchmark_main)
   add_test(NAME ${ITEM}_benchmark COMMAND ${ITEM}_benchmark
                                           
--benchmark_out=${ITEM}_benchmark.json)
   set_tests_properties(${ITEM}_benchmark PROPERTIES WORKING_DIRECTORY