This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/main by this push:
     new d17dce01d0 Fixed a warning build build: function never used. (#7577)
d17dce01d0 is described below

commit d17dce01d0c285e1d65fde91e6b8c7c5a7b208fc
Author: Jigao Luo <[email protected]>
AuthorDate: Sat May 31 22:18:37 2025 +0200

    Fixed a warning build build: function never used. (#7577)
    
    # Which issue does this PR close?
    
    No issue but I could create one
    
    # Rationale for this change
    
     This PR is simply fix the warning during building:
     ```
     warning: methods `selection` and `num_rows_selected` are never used
      --> parquet/src/arrow/arrow_reader/read_plan.rs:54:19
       |
    38 | impl ReadPlanBuilder {
       | -------------------- methods in this implementation
    ...
    54 |     pub(crate) fn selection(&self) -> Option<&RowSelection> {
       |                   ^^^^^^^^^
    ...
    78 |     pub(crate) fn num_rows_selected(&self) -> Option<usize> {
       |                   ^^^^^^^^^^^^^^^^^
       |
       = note: `#[warn(dead_code)]` on by default
    
    Compiling parquet_derive_test v55.1.0
    (..../arrow-rs/parquet_derive_test)
    warning: `parquet` (lib) generated 1 warning
     ```
    
    
    # What changes are included in this PR?
    
    No
    
    # Are there any user-facing changes?
    
    No
    
    ---------
    
    Signed-off-by: Jigao Luo <[email protected]>
---
 parquet/src/arrow/arrow_reader/read_plan.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/parquet/src/arrow/arrow_reader/read_plan.rs 
b/parquet/src/arrow/arrow_reader/read_plan.rs
index cf5d833850..e083fb822b 100644
--- a/parquet/src/arrow/arrow_reader/read_plan.rs
+++ b/parquet/src/arrow/arrow_reader/read_plan.rs
@@ -51,6 +51,7 @@ impl ReadPlanBuilder {
     }
 
     /// Returns the current selection, if any
+    #[cfg(feature = "async")]
     pub(crate) fn selection(&self) -> Option<&RowSelection> {
         self.selection.as_ref()
     }
@@ -75,6 +76,7 @@ impl ReadPlanBuilder {
     }
 
     /// Returns the number of rows selected, or `None` if all rows are 
selected.
+    #[cfg(feature = "async")]
     pub(crate) fn num_rows_selected(&self) -> Option<usize> {
         self.selection.as_ref().map(|s| s.row_count())
     }

Reply via email to