This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/main by this push:
     new b16c5400ee Remove redundant is_err checks in Variant tests (#7897)
b16c5400ee is described below

commit b16c5400ee3bdd2bec9bfedbe7e08d3efc2a7798
Author: Liang-Chi Hsieh <[email protected]>
AuthorDate: Fri Jul 11 04:50:48 2025 -0700

    Remove redundant is_err checks in Variant tests (#7897)
    
    # Which issue does this PR close?
    
    None
    
    # Rationale for this change
    
    Address the comment
    https://github.com/apache/arrow-rs/pull/7885#discussion_r2195436015.
    
    # What changes are included in this PR?
    
    Remove redundant `is_err` checks.
    
    # Are these changes tested?
    
    Existing tests.
    
    # Are there any user-facing changes?
    
    None
    
    Co-authored-by: Liang-Chi Hsieh <[email protected]>
    Co-authored-by: Andrew Lamb <[email protected]>
---
 parquet-variant/src/variant/object.rs | 2 --
 1 file changed, 2 deletions(-)

diff --git a/parquet-variant/src/variant/object.rs 
b/parquet-variant/src/variant/object.rs
index ea0c6fac0f..36c8f999b2 100644
--- a/parquet-variant/src/variant/object.rs
+++ b/parquet-variant/src/variant/object.rs
@@ -563,7 +563,6 @@ mod tests {
             b'e',
         ];
         let err = VariantMetadata::try_new(&metadata_bytes);
-        assert!(err.is_err());
         let err = err.unwrap_err();
         assert!(matches!(
             err,
@@ -611,7 +610,6 @@ mod tests {
         ];
 
         let err = VariantObject::try_new(metadata, &object_value);
-        assert!(err.is_err());
         let err = err.unwrap_err();
         assert!(matches!(
             err,

Reply via email to