This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new ad6261470 docs: fix safari rendering in manifest_load.mmd diagram
(#3391)
ad6261470 is described below
commit ad626147072f731bc571f25b58b7af703c0be1ba
Author: Bryce Mecum <[email protected]>
AuthorDate: Tue Sep 2 18:32:53 2025 -0700
docs: fix safari rendering in manifest_load.mmd diagram (#3391)
Fixes rendering of the manifest_load.mmd diagram under Safari by
re-generating the SVG using mmdc. The original SVG checked into git was
generated by hand using a web tool (mermaidchart.org)) which has a
rendering bug under Safari. The YAML frontmatter this PR removes is not
supported by the mmdc cli (it's specific to mermaidchart.org) so
removing it is also required for the makefile to run correctly anyway.
This PR is an overall improvement but has one downside: When using dark
mode, the connector lines between graph nodes is slightly less bright.
We might be able to fix this with custom CSS (via `mmdc --cssFile`).
Resolves #3292.
---
docs/source/format/manifest_load.mmd | 6 ------
docs/source/format/manifest_load.mmd.svg | 20 +++++++++++++++++++-
2 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/docs/source/format/manifest_load.mmd
b/docs/source/format/manifest_load.mmd
index 16de2161f..e95178345 100644
--- a/docs/source/format/manifest_load.mmd
+++ b/docs/source/format/manifest_load.mmd
@@ -15,12 +15,6 @@
%% specific language governing permissions and limitations
%% under the License.
----
-// [MermaidChart: 9800b551-3a02-4ce5-af92-c6d25d464d2b]
-config:
- theme: neo-dark
- layout: dagre
----
flowchart TD
Start["Driver name"] -- Has Extension --> R{"Is Relative Path?"}
Start -- No Extension --> Abs{{"Is Absolute Path?"}}
diff --git a/docs/source/format/manifest_load.mmd.svg
b/docs/source/format/manifest_load.mmd.svg
index 9960ba89e..744bd9976 100644
--- a/docs/source/format/manifest_load.mmd.svg
+++ b/docs/source/format/manifest_load.mmd.svg
@@ -1 +1,19 @@
-<svg id="export-svg" width="100%" xmlns="http://www.w3.org/2000/svg";
class="flowchart" style="max-width: 800.555px; background: rgb(23, 23, 25);"
viewBox="0 0 800.5546875 894.828125" role="graphics-document document"
aria-roledescription="flowchart-v2"><style
xmlns="http://www.w3.org/1999/xhtml";>@import
url("https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.2.0/css/all.min.css";);
p {margin:
0;}</style><style>#export-svg{font-family:arial,sans-serif;font-size:14px;fill:#ccc;}@keyframe
[...]
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+<svg aria-roledescription="flowchart-v2" role="graphics-document document"
viewBox="0 0 857.1985473632812 891.859375" style="max-width: 857.199px;
background-color: white;" class="flowchart"
xmlns:xlink="http://www.w3.org/1999/xlink"; xmlns="http://www.w3.org/2000/svg";
width="100%" id="my-svg"><style>#my-svg{font-family:"trebuchet
ms",verdana,arial,sans-serif;font-size:16px;fill:#333;}@keyframes
edge-animation-frame{from{stroke-dashoffset:0;}}@keyframes
dash{to{stroke-dashoffset:0;}}#my-s [...]
