This is an automated email from the ASF dual-hosted git repository.
zeroshade pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new 1883da38e ci(javascript): fix flaky msvc test (#4127)
1883da38e is described below
commit 1883da38ee6b9248a1a19345e027166563e3cdf1
Author: Kent Wu <[email protected]>
AuthorDate: Fri Mar 20 13:31:42 2026 -0400
ci(javascript): fix flaky msvc test (#4127)
This PR fixes the flaky msvc JavaScript tests.
Disables static SQLite build as it's not necessary for the test suite,
and sets `--config RelWithDebInfo` to ensure we build with the correct
config on windows.
**Test Plan**
Ran on my fork a few times and saw no more failures
https://github.com/kentkwu/arrow-adbc/actions/workflows/javascript.yml?query=event%3Aworkflow_dispatch+branch%3Agh-4124
closes #4124
---
ci/scripts/node_build.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/ci/scripts/node_build.sh b/ci/scripts/node_build.sh
index dca6afb8b..df83f2562 100755
--- a/ci/scripts/node_build.sh
+++ b/ci/scripts/node_build.sh
@@ -37,9 +37,10 @@ cmake -S "${REPO_ROOT}/c" -B "${OUT_DIR}" \
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
-DADBC_DRIVER_SQLITE=ON \
-DADBC_BUILD_TESTS=OFF \
- -DADBC_BUILD_SHARED=ON
+ -DADBC_BUILD_SHARED=ON \
+ -DADBC_BUILD_STATIC=OFF
-cmake --build "${OUT_DIR}" --target install -j
+cmake --build "${OUT_DIR}" --config RelWithDebInfo --target install -j
# 2. Build Node.js Package
echo "=== Building Node.js Package ==="
