This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/main by this push:
     new 1f07e54c12 Disable failing arrow_writer benchmark (#9638)
1f07e54c12 is described below

commit 1f07e54c1209a512f3ce15f4e576f0ca5d1c8d97
Author: Andrew Lamb <[email protected]>
AuthorDate: Wed Apr 1 10:09:37 2026 -0400

    Disable failing arrow_writer benchmark (#9638)
    
    # Which issue does this PR close?
    
    - Part of https://github.com/apache/arrow-rs/issues/9637
    # Rationale for this change
    
    I can't benchmark the arrow-writer changes in
    https://github.com/apache/arrow-rs/pull/9447 due to hitting a panic:
    - https://github.com/apache/arrow-rs/issues/9637
    
    # What changes are included in this PR?
    
    Temporarily disable the cdc benchmarks until the underlying bug is fixed
    
    # Are these changes tested?
    
    <!--
    We typically require tests for all PRs in order to:
    1. Prevent the code from being accidentally broken by subsequent changes
    2. Serve as another way to document the expected behavior of the code
    
    If tests are not included in your PR, please explain why (for example,
    are they covered by existing tests)?
    -->
    
    # Are there any user-facing changes?
    
    <!--
    If there are user-facing changes then we may require documentation to be
    updated before approving the PR.
    
    If there are any breaking changes to public APIs, please call them out.
    -->
---
 parquet/benches/arrow_writer.rs | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/parquet/benches/arrow_writer.rs b/parquet/benches/arrow_writer.rs
index 2381941897..0ee25873ab 100644
--- a/parquet/benches/arrow_writer.rs
+++ b/parquet/benches/arrow_writer.rs
@@ -34,7 +34,7 @@ use arrow::util::bench_util::{create_f16_array, 
create_f32_array, create_f64_arr
 use arrow::{record_batch::RecordBatch, util::data_gen::*};
 use arrow_array::RecordBatchOptions;
 use parquet::errors::Result;
-use parquet::file::properties::{CdcOptions, WriterProperties, WriterVersion};
+use parquet::file::properties::{WriterProperties, WriterVersion};
 
 fn create_primitive_bench_batch(
     size: usize,
@@ -420,10 +420,12 @@ fn create_writer_props() -> Vec<(&'static str, 
WriterProperties)> {
         .build();
     props.push(("zstd_parquet_2", prop));
 
-    let prop = WriterProperties::builder()
-        .set_content_defined_chunking(Some(CdcOptions::default()))
-        .build();
-    props.push(("cdc", prop));
+    // Disabled until https://github.com/apache/arrow-rs/issues/9637 is fixed
+    //
+    // let prop = WriterProperties::builder()
+    //    .set_content_defined_chunking(Some(CdcOptions::default()))
+    //    .build();
+    // props.push(("cdc", prop));
 
     props
 }

Reply via email to