kou commented on code in PR #774:
URL: https://github.com/apache/arrow-site/pull/774#discussion_r3049577947
##########
Rakefile:
##########
@@ -57,5 +58,7 @@ task :generate => webpacked_js do
command_line << "--config=_config.yml,#{extra_config}" if extra_config
destination = ENV["JEKYLL_DESTINATION"]
command_line << "--destination=#{destination}" if destination
+ future = ENV["JEKYLL_FUTURE"]
+ command_line << "--future" if future
Review Comment:
We can simplify this:
```suggestion
command_line << "--future" if ENV["JEKYLL_FUTURE"]
```
BTW, do we need this? If we need this, how about enable this only for
preview?
```diff
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index 9b963f13831..86236479f95 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -64,6 +64,9 @@ jobs:
export JEKYLL_DESTINATION=../build
export JEKYLL_ENV=production
export JEKYLL_EXTRA_CONFIG=_extra_config.yml
+ if [ "${GITHUB_REPOSITORY}" != "apache/arrow-site" ]; then
+ export JEKYLL_FUTURE=1
+ fi
bundle exec rake generate
- name: Checkout asf-site
uses: actions/checkout@v6
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
