This is an automated email from the ASF dual-hosted git repository.

thisisnic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 00a30c6eca MINOR: [C++] Remove obsolete TODO comment from mode kernel 
registration (#49122)
00a30c6eca is described below

commit 00a30c6ecab9d5dfb1a7eb7fc1ec39df250cf178
Author: Hyukjin Kwon <[email protected]>
AuthorDate: Tue Apr 21 10:21:33 2026 +0900

    MINOR: [C++] Remove obsolete TODO comment from mode kernel registration 
(#49122)
    
    ### Rationale for this change
    
    The TODO comment was added in commit 53752adc6b8 during the ExecSpan 
refactoring. It was, presumably, a reminder to migrate the mode kernel from the 
old `GenerateNumericOld` API to the new `GenerateNumeric` API. This migration 
was completed in commit 4d931ff1c0f, but the TODO comment was accidentally left 
behind.
    
    ### What changes are included in this PR?
    
    Removed the orphaned `// TODO(wesm):` comment from `aggregate_mode.cc`. The 
work it referenced was completed.
    
    ### Are these changes tested?
    
    No, I did not test.
    
    ### Are there any user-facing changes?
    
    No.
    
    Authored-by: Hyukjin Kwon <[email protected]>
    Signed-off-by: Nic Crane <[email protected]>
---
 cpp/src/arrow/compute/kernels/aggregate_mode.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/cpp/src/arrow/compute/kernels/aggregate_mode.cc 
b/cpp/src/arrow/compute/kernels/aggregate_mode.cc
index fbafa663b8..75786d12b6 100644
--- a/cpp/src/arrow/compute/kernels/aggregate_mode.cc
+++ b/cpp/src/arrow/compute/kernels/aggregate_mode.cc
@@ -495,7 +495,6 @@ void RegisterScalarAggregateMode(FunctionRegistry* 
registry) {
       NewModeKernel(boolean(), ModeExecutor<StructType, BooleanType>::Exec,
                     ModeExecutorChunked<StructType, BooleanType>::Exec)));
   for (const auto& type : NumericTypes()) {
-    // TODO(wesm):
     DCHECK_OK(func->AddKernel(
         NewModeKernel(type, GenerateNumeric<ModeExecutor, StructType>(*type),
                       GenerateNumeric<ModeExecutorChunked, 
StructType>(*type))));

Reply via email to