This is an automated email from the ASF dual-hosted git repository.
jonkeane pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 96f80729c1 GH-50014: [R] Replace imported symbol from bit64 (#50015)
96f80729c1 is described below
commit 96f80729c1581ee98f9d0a2cd9994ae50302491d
Author: Michael Chirico <[email protected]>
AuthorDate: Fri May 22 05:37:09 2026 -0700
GH-50014: [R] Replace imported symbol from bit64 (#50015)
I opted to delete the 'reexports' file because the symbols are not
_actually_ re-exported. IMHO, it's more appropriate to just add this hook in
arrow-package.R as done here, but of course if your strong preference is to
retain the reexports-bit64.R file I'll restore it.
`integer64()` should be a fine choice -- I basically wanted a part of the
API that has essentially 0 chance of ever changing.
As of today, `R CMD check` doesn't complain if you import a symbol and then
don't reference it in the sources. Nor do I think such a check will ever happen.
* GitHub Issue: #50014
Lead-authored-by: Michael Chirico <[email protected]>
Co-authored-by: Michael Chirico <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
---
r/DESCRIPTION | 1 -
r/NAMESPACE | 3 +--
r/R/arrow-package.R | 1 +
r/R/reexports-bit64.R | 22 ----------------------
r/man/reexports.Rd | 4 ----
5 files changed, 2 insertions(+), 29 deletions(-)
diff --git a/r/DESCRIPTION b/r/DESCRIPTION
index c76dfc5572..b65c95acca 100644
--- a/r/DESCRIPTION
+++ b/r/DESCRIPTION
@@ -147,7 +147,6 @@ Collate:
'query-engine.R'
'record-batch-reader.R'
'record-batch-writer.R'
- 'reexports-bit64.R'
'reexports-tidyselect.R'
'schema.R'
'udf.R'
diff --git a/r/NAMESPACE b/r/NAMESPACE
index f42944fb58..f74034c965 100644
--- a/r/NAMESPACE
+++ b/r/NAMESPACE
@@ -427,8 +427,7 @@ export(write_tsv_dataset)
importFrom(R6,R6Class)
importFrom(assertthat,assert_that)
importFrom(assertthat,is.string)
-importFrom(bit64,print.integer64)
-importFrom(bit64,str.integer64)
+importFrom(bit64,integer64)
importFrom(glue,glue)
importFrom(methods,as)
importFrom(purrr,as_mapper)
diff --git a/r/R/arrow-package.R b/r/R/arrow-package.R
index 750aff3f3b..2706faee5c 100644
--- a/r/R/arrow-package.R
+++ b/r/R/arrow-package.R
@@ -30,6 +30,7 @@
#' @importFrom rlang is_bare_list call_name
#' @importFrom tidyselect vars_pull eval_select eval_rename
#' @importFrom glue glue
+#' @importFrom bit64 integer64
#' @useDynLib arrow, .registration = TRUE
#' @keywords internal
"_PACKAGE"
diff --git a/r/R/reexports-bit64.R b/r/R/reexports-bit64.R
deleted file mode 100644
index c89d2b1509..0000000000
--- a/r/R/reexports-bit64.R
+++ /dev/null
@@ -1,22 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-#' @importFrom bit64 print.integer64
-bit64::print.integer64
-
-#' @importFrom bit64 str.integer64
-bit64::str.integer64
diff --git a/r/man/reexports.Rd b/r/man/reexports.Rd
index 591158c72f..c02ce79f87 100644
--- a/r/man/reexports.Rd
+++ b/r/man/reexports.Rd
@@ -3,8 +3,6 @@
\docType{import}
\name{reexports}
\alias{reexports}
-\alias{print.integer64}
-\alias{str.integer64}
\alias{contains}
\alias{select_helpers}
\alias{ends_with}
@@ -22,8 +20,6 @@ These objects are imported from other packages. Follow the
links
below to see their documentation.
\describe{
- \item{bit64}{\code{\link[bit64:bit64-package]{print.integer64}},
\code{\link[bit64:bit64-package]{str.integer64}}}
-
\item{tidyselect}{\code{\link[tidyselect]{all_of}},
\code{\link[tidyselect:starts_with]{contains}},
\code{\link[tidyselect:starts_with]{ends_with}},
\code{\link[tidyselect]{everything}},
\code{\link[tidyselect:everything]{last_col}},
\code{\link[tidyselect:starts_with]{matches}},
\code{\link[tidyselect:starts_with]{num_range}},
\code{\link[tidyselect]{one_of}}, \code{\link[tidyselect]{starts_with}}}
}}
