This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/main by this push:
new 9d5d79be99 test(parquet): drop confusing `main` reference in
page-roundtrip test comment (#10072)
9d5d79be99 is described below
commit 9d5d79be99fbe7671fce1b4dd55606510f93d5d0
Author: Adrian Garcia Badaracco <[email protected]>
AuthorDate: Fri Jun 5 13:47:26 2026 -0400
test(parquet): drop confusing `main` reference in page-roundtrip test
comment (#10072)
# Which issue does this PR close?
Follow-up to #9972.
# Rationale for this change
A test comment added in #9972 described granular mode as writing "more
pages than `main`". As noted in [review
feedback](https://github.com/apache/arrow-rs/pull/9972#discussion_r3357602241),
comparing to `main` is confusing now that the PR has merged — that code
*is* main. This rephrases the comment to compare against the default
batched path instead, which the same comment already references.
# What changes are included in this PR?
- Reword one test comment in
`test_arrow_writer_granular_mode_roundtrip`. No behavior change.
# Are there any user-facing changes?
No.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
---
parquet/src/arrow/arrow_writer/mod.rs | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/parquet/src/arrow/arrow_writer/mod.rs
b/parquet/src/arrow/arrow_writer/mod.rs
index 21650fe26e..9e61c57514 100644
--- a/parquet/src/arrow/arrow_writer/mod.rs
+++ b/parquet/src/arrow/arrow_writer/mod.rs
@@ -5259,10 +5259,10 @@ mod tests {
#[test]
fn test_arrow_writer_granular_mode_roundtrip() {
- // Granular mode subdivides chunks and writes more pages than
- // `main`. Make sure the data we write back is bit-identical to
- // what went in — page-count assertions elsewhere only prove
- // pages were cut, not that the encoded data is correct.
+ // Granular mode subdivides chunks and writes more pages than the
+ // default batched path. Make sure the data we write back is
+ // bit-identical to what went in — page-count assertions elsewhere
+ // only prove pages were cut, not that the encoded data is correct.
//
// Mix value sizes so that the cumulative-byte-budget cutoff
// lands mid-chunk, exercising both batched and granular paths
