(arrow-rs) branch main updated: chore: update `Bytes` visibility to correctly reflect the actual visibility (#10115)

[alamb]

This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/main by this push:
     new 8d2333cd0a chore: update `Bytes` visibility to correctly reflect the 
actual visibility (#10115)
8d2333cd0a is described below

commit 8d2333cd0ac40a0aa6d9986feb3b2386647e5289
Author: Raz Luvaton <16746759+rluva...@users.noreply.github.com>
AuthorDate: Fri Jun 12 00:09:43 2026 +0300

    chore: update `Bytes` visibility to correctly reflect the actual visibility 
(#10115)
    
    # Which issue does this PR close?
    
    N/A
    
    # Rationale for this change
    
    although `Bytes` and some of its functions are marked as `pub` it is
    never exposed outside the crate.
    updated this so reading the code will be less confusing
    
    # What changes are included in this PR?
    
    changed `pub` to `pub(crate)` in `Bytes` impl
    
    # Are these changes tested?
    
    existing tests
    
    # Are there any user-facing changes?
    
    no since it was never exposed anyway
---
 arrow-buffer/src/bytes.rs | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/arrow-buffer/src/bytes.rs b/arrow-buffer/src/bytes.rs
index 8f912b807d..a80a347fa1 100644
--- a/arrow-buffer/src/bytes.rs
+++ b/arrow-buffer/src/bytes.rs
@@ -45,7 +45,7 @@ use std::sync::Mutex;
 /// When the region is allocated by a different allocator, 
[Deallocation::Custom], this calls the
 /// custom deallocator to deallocate the region when it is no longer needed.
 ///
-pub struct Bytes {
+pub(crate) struct Bytes {
     /// The raw pointer to be beginning of the region
     ptr: NonNull<u8>,
 
@@ -89,21 +89,16 @@ impl Bytes {
     }
 
     #[inline]
-    pub fn len(&self) -> usize {
+    pub(crate) fn len(&self) -> usize {
         self.len
     }
 
     #[inline]
-    pub fn is_empty(&self) -> bool {
-        self.len == 0
-    }
-
-    #[inline]
-    pub fn ptr(&self) -> NonNull<u8> {
+    pub(crate) fn ptr(&self) -> NonNull<u8> {
         self.ptr
     }
 
-    pub fn capacity(&self) -> usize {
+    pub(crate) fn capacity(&self) -> usize {
         match self.deallocation {
             Deallocation::Standard(layout) => layout.size(),
             // we only know the size of the custom allocation
@@ -114,7 +109,7 @@ impl Bytes {
 
     /// Register this [`Bytes`] with the provided [`MemoryPool`], replacing 
any prior reservation.
     #[cfg(feature = "pool")]
-    pub fn claim(&self, pool: &dyn MemoryPool) {
+    pub(crate) fn claim(&self, pool: &dyn MemoryPool) {
         *self.reservation.lock().unwrap() = 
Some(pool.reserve(self.capacity()));
     }
 
@@ -139,7 +134,7 @@ impl Bytes {
     /// Returns `Err` if the memory was allocated with a custom allocator,
     /// or the call to `realloc` failed, for whatever reason.
     /// In case of `Err`, the [`Bytes`] will remain as it was (i.e. have the 
old size).
-    pub fn try_realloc(&mut self, new_len: usize) -> Result<(), ()> {
+    pub(crate) fn try_realloc(&mut self, new_len: usize) -> Result<(), ()> {
         if let Deallocation::Standard(old_layout) = self.deallocation {
             if old_layout.size() == new_len {
                 return Ok(()); // Nothing to do