This is an automated email from the ASF dual-hosted git repository.
pitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 60615a55e6 GH-50212: [C++][Parquet] Add PrintTo to fix failure in
parquet-internals-test on test-conda-cpp-valgrind (#50213)
60615a55e6 is described below
commit 60615a55e6341d038e8129d2d60b3ef3184fb1ff
Author: tadeja <[email protected]>
AuthorDate: Thu Jun 18 14:58:06 2026 +0200
GH-50212: [C++][Parquet] Add PrintTo to fix failure in
parquet-internals-test on test-conda-cpp-valgrind (#50213)
### Rationale for this change
Fix #50212
`Test #89: parquet-internals-test .......................***Failed 14.96
sec`
### What changes are included in this PR?
Add custom `PrintTo` for parameter `BloomFilterBuilderFoldingTestCase`
introduced with pr #50008, so gtest prints fields instead of raw bytes (error
`Use of uninitialised value`).
Similar to the past solution in commit 1b7e3967 but with additional field
names/debug output.
### Are these changes tested?
Yes, by CI.
### Are there any user-facing changes?
No.
* GitHub Issue: #50212
Authored-by: Tadeja Kadunc <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
---
cpp/src/parquet/bloom_filter_reader_writer_test.cc | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/cpp/src/parquet/bloom_filter_reader_writer_test.cc
b/cpp/src/parquet/bloom_filter_reader_writer_test.cc
index 2750fde029..bbbdc2ff19 100644
--- a/cpp/src/parquet/bloom_filter_reader_writer_test.cc
+++ b/cpp/src/parquet/bloom_filter_reader_writer_test.cc
@@ -159,6 +159,12 @@ struct BloomFilterBuilderFoldingTestCase {
int64_t expected_bitset_ndv;
};
+void PrintTo(const BloomFilterBuilderFoldingTestCase& test_case, std::ostream*
os) {
+ *os << "{ndv=" << test_case.ndv << ", fold=" << test_case.fold
+ << ", inserted_count=" << test_case.inserted_count
+ << ", expected_bitset_ndv=" << test_case.expected_bitset_ndv << "}";
+}
+
class BloomFilterBuilderFoldingTest
: public ::testing::TestWithParam<BloomFilterBuilderFoldingTestCase> {};