This is an automated email from the ASF dual-hosted git repository.

paleolimbot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-nanoarrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 24a899ae fix(python): Check error code for ArrowMetadataReaderRead in 
Python bindings (#908)
24a899ae is described below

commit 24a899aeeb5aaec92d32baefcc7fa8d2cef1c1a9
Author: Andrew Kane <[email protected]>
AuthorDate: Tue Jul 21 19:27:45 2026 -0700

    fix(python): Check error code for ArrowMetadataReaderRead in Python 
bindings (#908)
    
    The error code was previously unused.
---
 python/src/nanoarrow/_schema.pyx | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/python/src/nanoarrow/_schema.pyx b/python/src/nanoarrow/_schema.pyx
index 76353769..d499d1c8 100644
--- a/python/src/nanoarrow/_schema.pyx
+++ b/python/src/nanoarrow/_schema.pyx
@@ -226,9 +226,11 @@ cdef class SchemaMetadata:
         The result may contain duplicate keys if they exist in the metadata."""
         cdef ArrowStringView key
         cdef ArrowStringView value
+        cdef int code
         self._init_reader()
         while self._reader.remaining_keys > 0:
-            ArrowMetadataReaderRead(&self._reader, &key, &value)
+            code = ArrowMetadataReaderRead(&self._reader, &key, &value)
+            Error.raise_error_not_ok("ArrowMetadataReaderRead()", code)
             key_obj = PyBytes_FromStringAndSize(key.data, key.size_bytes)
             value_obj = PyBytes_FromStringAndSize(value.data, value.size_bytes)
             yield key_obj, value_obj

Reply via email to