This is an automated email from the ASF dual-hosted git repository.
CurtHagenlocher pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-dotnet.git
The following commit(s) were added to refs/heads/main by this push:
new acf1436 chore: enable more Python types in C Data Interface tests
(#401)
acf1436 is described below
commit acf14364b06c157d25b850bae41a7586795050a8
Author: Adam Reeve <[email protected]>
AuthorDate: Fri Aug 7 03:47:35 2026 +1200
chore: enable more Python types in C Data Interface tests (#401)
CI uses the latest PyArrow release, which is 25.0.0 and has support for
the `ListView`, `BinaryView`, `StringView`, `Decimal32`, and `Decimal64`
types. These were previously excluded from the C Data Interface tests
when PyArrow didn't support them, so enable them now.
---
test/Apache.Arrow.Tests/CDataInterfacePythonTests.cs | 18 ++++++++++++------
.../CDeviceDataInterfacePythonTests.cs | 3 +--
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/test/Apache.Arrow.Tests/CDataInterfacePythonTests.cs
b/test/Apache.Arrow.Tests/CDataInterfacePythonTests.cs
index 843be18..fa6c56c 100644
--- a/test/Apache.Arrow.Tests/CDataInterfacePythonTests.cs
+++ b/test/Apache.Arrow.Tests/CDataInterfacePythonTests.cs
@@ -58,6 +58,8 @@ namespace Apache.Arrow.Tests
.Field(f =>
f.Name("f32").DataType(FloatType.Default).Nullable(true))
.Field(f =>
f.Name("f64").DataType(DoubleType.Default).Nullable(true))
+ .Field(f => f.Name("decimal32_9_3").DataType(new
Decimal32Type(9, 3)).Nullable(true))
+ .Field(f => f.Name("decimal64_18_3").DataType(new
Decimal64Type(18, 3)).Nullable(true))
.Field(f => f.Name("decimal128_19_3").DataType(new
Decimal128Type(19, 3)).Nullable(true))
.Field(f => f.Name("decimal256_19_3").DataType(new
Decimal256Type(19, 3)).Nullable(true))
.Field(f => f.Name("decimal256_40_2").DataType(new
Decimal256Type(40, 2)).Nullable(false))
@@ -65,6 +67,8 @@ namespace Apache.Arrow.Tests
.Field(f =>
f.Name("binary").DataType(BinaryType.Default).Nullable(false))
.Field(f =>
f.Name("string").DataType(StringType.Default).Nullable(false))
.Field(f => f.Name("fw_binary_10").DataType(new
FixedSizeBinaryType(10)).Nullable(false))
+ .Field(f =>
f.Name("binary_view").DataType(BinaryViewType.Default).Nullable(false))
+ .Field(f =>
f.Name("string_view").DataType(StringViewType.Default).Nullable(false))
.Field(f =>
f.Name("date32").DataType(Date32Type.Default).Nullable(false))
.Field(f =>
f.Name("date64").DataType(Date64Type.Default).Nullable(false))
@@ -79,6 +83,7 @@ namespace Apache.Arrow.Tests
.Field(f => f.Name("list_string").DataType(new
ListType(StringType.Default)).Nullable(false))
.Field(f => f.Name("list_list_i32").DataType(new
ListType(new ListType(Int32Type.Default))).Nullable(false))
+ .Field(f => f.Name("list_view_string").DataType(new
ListViewType(StringType.Default)).Nullable(false))
.Field(f => f.Name("fixed_length_list_i64").DataType(new
FixedSizeListType(Int64Type.Default, 10)).Nullable(true))
@@ -130,6 +135,8 @@ namespace Apache.Arrow.Tests
yield return pa.field("f32", pa.float32(), true);
yield return pa.field("f64", pa.float64(), true);
+ yield return pa.field("decimal32_9_3", pa.decimal32(9, 3),
true);
+ yield return pa.field("decimal64_18_3", pa.decimal64(18, 3),
true);
yield return pa.field("decimal128_19_3", pa.decimal128(19, 3),
true);
yield return pa.field("decimal256_19_3", pa.decimal256(19, 3),
true);
yield return pa.field("decimal256_40_2", pa.decimal256(40, 2),
false);
@@ -137,6 +144,8 @@ namespace Apache.Arrow.Tests
yield return pa.field("binary", pa.binary(), false);
yield return pa.field("string", pa.utf8(), false);
yield return pa.field("fw_binary_10", pa.binary(10), false);
+ yield return pa.field("binary_view", pa.binary_view(), false);
+ yield return pa.field("string_view", pa.string_view(), false);
yield return pa.field("date32", pa.date32(), false);
yield return pa.field("date64", pa.date64(), false);
@@ -151,6 +160,7 @@ namespace Apache.Arrow.Tests
yield return pa.field("list_string", pa.list_(pa.utf8()),
false);
yield return pa.field("list_list_i32",
pa.list_(pa.list_(pa.int32())), false);
+ yield return pa.field("list_view_string",
pa.list_view(pa.utf8()), false);
yield return pa.field("fixed_length_list_i64",
pa.list_(pa.int64(), 10), true);
@@ -769,9 +779,7 @@ namespace Apache.Arrow.Tests
[SkippableFact]
public unsafe void RoundTripTestBatch()
{
- // TODO: Enable these once this the version of pyarrow referenced
during testing supports them
- HashSet<ArrowTypeId> unsupported = new HashSet<ArrowTypeId> {
ArrowTypeId.ListView, ArrowTypeId.BinaryView, ArrowTypeId.StringView,
ArrowTypeId.Decimal32, ArrowTypeId.Decimal64 };
- RecordBatch batch1 = TestData.CreateSampleRecordBatch(4,
excludedTypes: unsupported);
+ RecordBatch batch1 = TestData.CreateSampleRecordBatch(4);
RecordBatch batch2 = batch1.Clone();
CArrowArray* cExportArray = CArrowArray.Create();
@@ -811,9 +819,7 @@ namespace Apache.Arrow.Tests
[SkippableFact]
public unsafe void RoundTripTestSlicedBatch()
{
- // TODO: Enable these once this the version of pyarrow referenced
during testing supports them
- HashSet<ArrowTypeId> unsupported = new HashSet<ArrowTypeId> {
ArrowTypeId.ListView, ArrowTypeId.BinaryView, ArrowTypeId.StringView,
ArrowTypeId.Decimal32, ArrowTypeId.Decimal64 };
- RecordBatch batch1 = TestData.CreateSampleRecordBatch(4,
excludedTypes: unsupported);
+ RecordBatch batch1 = TestData.CreateSampleRecordBatch(4);
RecordBatch batch1slice = batch1.Slice(1, 2);
RecordBatch batch2 = batch1slice.Clone();
diff --git a/test/Apache.Arrow.Tests/CDeviceDataInterfacePythonTests.cs
b/test/Apache.Arrow.Tests/CDeviceDataInterfacePythonTests.cs
index 339d494..c02dd4b 100644
--- a/test/Apache.Arrow.Tests/CDeviceDataInterfacePythonTests.cs
+++ b/test/Apache.Arrow.Tests/CDeviceDataInterfacePythonTests.cs
@@ -238,8 +238,7 @@ namespace Apache.Arrow.Tests
public unsafe void RoundTripTestBatchViaDevice()
{
// C# -> Python (via device) -> C# round trip
- HashSet<ArrowTypeId> unsupported = new HashSet<ArrowTypeId> {
ArrowTypeId.ListView, ArrowTypeId.BinaryView, ArrowTypeId.StringView,
ArrowTypeId.Decimal32, ArrowTypeId.Decimal64 };
- RecordBatch batch1 = TestData.CreateSampleRecordBatch(4,
excludedTypes: unsupported);
+ RecordBatch batch1 = TestData.CreateSampleRecordBatch(4);
RecordBatch batch2 = batch1.Clone();
CArrowDeviceArray* cExportDeviceArray = CArrowDeviceArray.Create();
