This is an automated email from the ASF dual-hosted git repository.

Jefffrey pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/main by this push:
     new 5ce0ebed18 minor: fix benchmark name (#10705)
5ce0ebed18 is described below

commit 5ce0ebed185a805f0a2bb744c93a7cbdccc819b6
Author: RIchard Baah <[email protected]>
AuthorDate: Sun Aug 16 02:35:21 2026 -0400

    minor: fix benchmark name (#10705)
    
    # Which issue does this PR close?
    
    <!--
    We generally require a GitHub issue to be filed for all bug fixes and
    enhancements and this helps us generate change logs for our releases.
    You can link an issue to this PR using the GitHub syntax.
    -->
    
    - context
    https://github.com/apache/arrow-rs/pull/10438#issuecomment-5306059829
    
    # Rationale for this change
    see
    https://github.com/apache/arrow-rs/pull/10438#issuecomment-5306059829
    <!--
    Why are you proposing this change? If this is already explained clearly
    in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand
    your changes and offer better suggestions for fixes.
    -->
    
    # What changes are included in this PR?
    update benchmark names
    <!--
    There is no need to duplicate the description in the issue here but it
    is sometimes worth providing a summary of the individual changes in this
    PR.
    -->
    
    # Are these changes tested?
    n/a
    <!--
    We typically require tests for all PRs in order to:
    1. Prevent the code from being accidentally broken by subsequent changes
    2. Serve as another way to document the expected behavior of the code
    
    If tests are not included in your PR, please explain why (for example,
    are they covered by existing tests)?
    
    If this PR claims a performance improvement, please include evidence
    such as benchmark results.
    -->
    
    # Are there any user-facing changes?
    n/a
    <!--
    If there are user-facing changes then we may require documentation to be
    updated before approving the PR.
    
    If there are any breaking changes to public APIs, please call them out.
    -->
---
 arrow-array/benches/boolean_array.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arrow-array/benches/boolean_array.rs 
b/arrow-array/benches/boolean_array.rs
index 0c0cac323a..f64440a795 100644
--- a/arrow-array/benches/boolean_array.rs
+++ b/arrow-array/benches/boolean_array.rs
@@ -73,7 +73,7 @@ fn criterion_benchmark(c: &mut Criterion) {
 
         // take_n_true: mixed true/false
         let bool_vec: Vec<bool> = (0..len).map(|idx| idx % 3 != 0).collect();
-        c.bench_function(&format!("take_n_true({})", len / 2), |b| {
+        c.bench_function(&format!("take_n_true_unique({})", len / 2), |b| {
             b.iter_batched(
                 || BooleanArray::from(bool_vec.clone()), // fresh buffer, 
strong_count == 1
                 |arr| hint::black_box(arr).take_n_true(len / 2),
@@ -83,7 +83,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         // underlying buffer is shared
         let mixed_boolean_array_shared = BooleanArray::from(bool_vec);
         let shared_array = mixed_boolean_array_shared.clone();
-        c.bench_function(&format!("take_n_true({})", len / 2), |b| {
+        c.bench_function(&format!("take_n_true_shared({})", len / 2), |b| {
             b.iter_batched(
                 || shared_array.clone(), // strong_count >= 2, forces copy path
                 |arr| hint::black_box(arr).take_n_true(len / 2),

Reply via email to