(arrow-java) branch main updated: MINOR: actually throw in PooledByteBufAllocatorL (#1259)

[lidavidm]

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-java.git


The following commit(s) were added to refs/heads/main by this push:
     new 522b0a26b MINOR: actually throw in PooledByteBufAllocatorL (#1259)
522b0a26b is described below

commit 522b0a26b69024197ccb619d1d220701338b854c
Author: Dan Homola <dan.hom...@hotmail.cz>
AuthorDate: Tue Aug 25 13:48:08 2026 +0200

    MINOR: actually throw in PooledByteBufAllocatorL (#1259)
    
    ## What's Changed
    
    There was a check in that class that looks like it throws an exception,
    but actually does not. This means that when that branch is hit, instead
    of an actionable error, the user gets a ClassCastException like
    
    ```
    java.lang.ClassCastException: class io.netty.buffer.PooledDirectByteBuf 
cannot be cast to class io.netty.buffer.PooledUnsafeDirectByteBuf 
(io.netty.buffer.PooledDirectByteBuf and 
io.netty.buffer.PooledUnsafeDirectByteBuf are in unnamed module of loader 
org.springframework.boot.loader.launch.LaunchedClassLoader@5e9f23b4)
    ```
    
    Actually throwing the exception prevents this and should not break
    anything: there is still an exception being thrown, just a different
    type.
    
    Also, make getNormalBufferCount actually return the count, not the size.
---
 .../src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/memory/memory-netty-buffer-patch/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java
 
b/memory/memory-netty-buffer-patch/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java
index b3d79c34c..44031a2d4 100644
--- 
a/memory/memory-netty-buffer-patch/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java
+++ 
b/memory/memory-netty-buffer-patch/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java
@@ -82,7 +82,7 @@ public class PooledByteBufAllocatorL {
   }
 
   public long getNormalBufferCount() {
-    return normalBufferSize.get();
+    return normalBufferCount.get();
   }
 
   private static class AccountedUnsafeDirectLittleEndian extends 
UnsafeDirectLittleEndian {
@@ -172,7 +172,7 @@ public class PooledByteBufAllocatorL {
           // within chunk, use arena.
           ByteBuf buf = directArena.allocate(cache, initialCapacity, 
maxCapacity);
           if (!(buf instanceof PooledUnsafeDirectByteBuf)) {
-            fail();
+            throw fail();
           }
 
           if (!AssertionUtil.ASSERT_ENABLED) {