This is an automated email from the ASF dual-hosted git repository.
Jefffrey pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/main by this push:
new 2ea4a7348d introduce union and REE take benchmarks (#10819)
2ea4a7348d is described below
commit 2ea4a7348de76ebb33a0a07e4992890e57d0bbfb
Author: RIchard Baah <[email protected]>
AuthorDate: Wed Aug 26 21:51:44 2026 -0400
introduce union and REE take benchmarks (#10819)
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax.
-->
- Closes #10815 if #10816 is also closed.
# Rationale for this change
UnionArray (sparse and dense) and RunArray had no benchmark coverage in
the take kernel suite.
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
Adds benchmarks to arrow/benches/take_kernels.rs for:
- Sparse and dense UnionArray (Int32 + Float64 children, sizes 512
and 1024). Union has no top-level validity bitmap so null-value variants
are omitted.
- RunArray<Utf8> benchmarks standard 1024/512 null/no-null
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
# Are these changes tested?
n/a
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
If this PR claims a performance improvement, please include evidence
such as benchmark results.
-->
# Are there any user-facing changes?
no
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
-->
---
arrow/benches/take_kernels.rs | 140 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 140 insertions(+)
diff --git a/arrow/benches/take_kernels.rs b/arrow/benches/take_kernels.rs
index 8afc4ff17e..2967f65221 100644
--- a/arrow/benches/take_kernels.rs
+++ b/arrow/benches/take_kernels.rs
@@ -19,6 +19,7 @@
extern crate criterion;
use criterion::Criterion;
+use arrow_buffer::ScalarBuffer;
use rand::RngExt;
use arrow::compute::{TakeOptions, take, take_record_batch};
@@ -71,6 +72,100 @@ fn bench_take_bounds_check(values: &dyn Array, indices:
&UInt32Array) {
hint::black_box(take(values, indices, Some(TakeOptions { check_bounds:
true })).unwrap());
}
+fn create_string_run_array(logical_len: usize, physical_len: usize) ->
RunArray<Int32Type> {
+ let strings = create_string_array_for_runs(physical_len, logical_len, 8);
+ let mut builder = GenericByteRunBuilder::<Int32Type, Utf8Type>::new();
+ for s in &strings {
+ builder.append_value(s.as_str());
+ }
+ builder.finish()
+}
+
+fn create_sparse_union(size: usize) -> UnionArray {
+ let mut rng = seedable_rng();
+ let type_ids: ScalarBuffer<i8> = (0..size).map(|_|
rng.random_range(0_i8..4)).collect();
+ let int_array: Int32Array = (0..size).map(|_|
Some(rng.random::<i32>())).collect();
+ let float_array: Float64Array = (0..size).map(|_|
Some(rng.random::<f64>())).collect();
+ let string_array = StringArray::from_iter((0..size).map(|i|
Some(format!("basic_string:{i}"))));
+ let fsb_array = create_fsb_array(size, 0.0, 16);
+ let fields = [
+ (0, Arc::new(Field::new("a", DataType::Int32, false))),
+ (1, Arc::new(Field::new("b", DataType::Float64, false))),
+ (2, Arc::new(Field::new("c", DataType::Utf8, false))),
+ (
+ 3,
+ Arc::new(Field::new("d", DataType::FixedSizeBinary(16), false)),
+ ),
+ ]
+ .into_iter()
+ .collect::<UnionFields>();
+ UnionArray::try_new(
+ fields,
+ type_ids,
+ None,
+ vec![
+ Arc::new(int_array),
+ Arc::new(float_array),
+ Arc::new(string_array),
+ Arc::new(fsb_array),
+ ],
+ )
+ .unwrap()
+}
+
+fn create_dense_union(size: usize) -> UnionArray {
+ let mut rng = seedable_rng();
+ let mut int_vals: Vec<i32> = Vec::new();
+ let mut float_vals: Vec<f64> = Vec::new();
+ let mut fsb_vals: Vec<[u8; 16]> = Vec::new();
+ let mut type_ids = Vec::with_capacity(size);
+ let mut offsets = Vec::with_capacity(size);
+ for _ in 0..size {
+ let tid = rng.random_range(0_i8..3);
+ type_ids.push(tid);
+ match tid {
+ 0 => {
+ offsets.push(int_vals.len() as i32);
+ int_vals.push(rng.random());
+ }
+ 1 => {
+ offsets.push(float_vals.len() as i32);
+ float_vals.push(rng.random());
+ }
+ _ => {
+ offsets.push(fsb_vals.len() as i32);
+ fsb_vals.push(rng.random());
+ }
+ }
+ }
+ let type_ids: ScalarBuffer<i8> = type_ids.into_iter().collect();
+ let offsets: ScalarBuffer<i32> = offsets.into_iter().collect();
+ let int_array: Int32Array = int_vals.into_iter().map(Some).collect();
+ let float_array: Float64Array = float_vals.into_iter().map(Some).collect();
+ let fsb_array =
FixedSizeBinaryArray::try_from_iter(fsb_vals.into_iter()).unwrap();
+ let fields = [
+ (0, Arc::new(Field::new("a", DataType::Int32, false))),
+ (1, Arc::new(Field::new("b", DataType::Float64, false))),
+ (
+ 2,
+ Arc::new(Field::new("c", DataType::FixedSizeBinary(16), false)),
+ ),
+ ]
+ .into_iter()
+ .collect::<UnionFields>();
+ UnionArray::try_new(
+ fields,
+ type_ids,
+ Some(offsets),
+ vec![
+ Arc::new(int_array),
+ Arc::new(float_array),
+ Arc::new(fsb_array),
+ ],
+ )
+ .unwrap()
+}
+
fn add_benchmark(c: &mut Criterion) {
let values = create_primitive_array::<Int32Type>(512, 0.0);
let indices = create_random_index(512, 0.0);
@@ -273,6 +368,27 @@ fn add_benchmark(c: &mut Criterion) {
|b| b.iter(|| bench_take(&values, &indices)),
);
+ let values = create_string_run_array(1024, 128);
+ let indices = create_random_index(1024, 0.0);
+ c.bench_function(
+ "take string run logical len: 1024, physical len: 128, indices: 1024",
+ |b| b.iter(|| bench_take(&values, &indices)),
+ );
+
+ let values = create_string_run_array(1024, 512);
+ let indices = create_random_index(1024, 0.0);
+ c.bench_function(
+ "take string run logical len: 1024, physical len: 512, indices: 1024",
+ |b| b.iter(|| bench_take(&values, &indices)),
+ );
+
+ let values = create_string_run_array(1024, 512);
+ let indices = create_random_index(1024, 0.5);
+ c.bench_function(
+ "take string run logical len: 1024, physical len: 512, null indices:
1024",
+ |b| b.iter(|| bench_take(&values, &indices)),
+ );
+
let values = create_fsb_array(1024, 0.0, 12);
let indices = create_random_index(1024, 0.0);
c.bench_function("take fsb value len: 12, indices: 1024", |b| {
@@ -418,6 +534,30 @@ fn add_benchmark(c: &mut Criterion) {
c.bench_function("take map<str, i32> null indices 1024", |b| {
b.iter(|| bench_take(&values, &indices))
});
+
+ let values = create_sparse_union(512);
+ let indices = create_random_index(512, 0.0);
+ c.bench_function("take sparse union 512", |b| {
+ b.iter(|| bench_take(&values, &indices))
+ });
+
+ let values = create_sparse_union(1024);
+ let indices = create_random_index(1024, 0.0);
+ c.bench_function("take sparse union 1024", |b| {
+ b.iter(|| bench_take(&values, &indices))
+ });
+
+ let values = create_dense_union(512);
+ let indices = create_random_index(512, 0.0);
+ c.bench_function("take dense union 512", |b| {
+ b.iter(|| bench_take(&values, &indices))
+ });
+
+ let values = create_dense_union(1024);
+ let indices = create_random_index(1024, 0.0);
+ c.bench_function("take dense union 1024", |b| {
+ b.iter(|| bench_take(&values, &indices))
+ });
}
criterion_group!(benches, add_benchmark);
