(arrow) branch main updated: GH-49970: [GLib] Enable tests for custom extension data type (#49971)

[kou]

This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 958724151a GH-49970: [GLib] Enable tests for custom extension data 
type (#49971)
958724151a is described below

commit 958724151aec208ff01865cd8f4a5031e9210a38
Author: Sutou Kouhei <k...@clear-code.com>
AuthorDate: Thu Sep 3 15:27:26 2026 +0900

    GH-49970: [GLib] Enable tests for custom extension data type (#49971)
    
    ### Rationale for this change
    
    There are some omitted custom extension data type tests because 
gobject-introspection gem doesn't have enough features. But recent 
gobject-introspection gem provides these features.
    
    ### What changes are included in this PR?
    
    Enable omitted tests with recent gobject-introspection gem.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    No.
    * GitHub Issue: #49970
    
    Authored-by: Sutou Kouhei <k...@clear-code.com>
    Signed-off-by: Sutou Kouhei <k...@clear-code.com>
---
 c_glib/test/test-extension-data-type.rb | 23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/c_glib/test/test-extension-data-type.rb 
b/c_glib/test/test-extension-data-type.rb
index 8dfee88518..6d49b83a04 100644
--- a/c_glib/test/test-extension-data-type.rb
+++ b/c_glib/test/test-extension-data-type.rb
@@ -27,15 +27,14 @@ class TestExtensionDataType < Test::Unit::TestCase
       super(storage_data_type: Arrow::FixedSizeBinaryDataType.new(16))
     end
 
-    # TODO
-    # def get_extension_name_impl
-    #   "uuid"
-    # end
+    private
+    def virtual_do_get_extension_name
+      "uuid"
+    end
 
-    # TODO
-    # def get_array_gtype_impl
-    #   UUIDArray.gtype
-    # end
+    def virtual_do_get_array_gtype
+      UUIDArray.gtype
+    end
   end
 
   include Helper::Buildable
@@ -51,7 +50,6 @@ class TestExtensionDataType < Test::Unit::TestCase
   end
 
   def test_to_s
-    omit("gobject-introspection gem doesn't support implementing methods for 
GLib object yet")
     data_type = UUIDDataType.new
     assert_equal("extension<uuid>", data_type.to_s)
   end
@@ -63,13 +61,11 @@ class TestExtensionDataType < Test::Unit::TestCase
   end
 
   def test_extension_name
-    omit("gobject-introspection gem doesn't support implementing methods for 
GLib object yet")
     data_type = UUIDDataType.new
     assert_equal("uuid", data_type.extension_name)
   end
 
   def test_wrap_array
-    omit("gobject-introspection gem doesn't support implementing methods for 
GLib object yet")
     data_type = UUIDDataType.new
     storage = build_fixed_size_binary_array(data_type.storage_data_type,
                                             ["a" * 16, nil, "c" * 16])
@@ -85,7 +81,6 @@ class TestExtensionDataType < Test::Unit::TestCase
   end
 
   def test_wrap_chunked_array
-    omit("gobject-introspection gem doesn't support implementing methods for 
GLib object yet")
     data_type = UUIDDataType.new
     storage1 = build_fixed_size_binary_array(data_type.storage_data_type,
                                              ["a" * 16, nil])
@@ -95,10 +90,10 @@ class TestExtensionDataType < Test::Unit::TestCase
     extension_chunked_array = data_type.wrap_chunked_array(chunked_array)
     assert_equal([
                    data_type,
-                   [UUIDArray] * chunked_array.size,
+                   [UUIDArray] * chunked_array.n_chunks,
                  ],
                  [
-                   extension_chunked_array.get_value_data_type,
+                   extension_chunked_array.value_data_type,
                    extension_chunked_array.chunks.collect(&:class),
                  ])
   end