(arrow-rs) branch main updated: chore: cut down amount of zip benchmarks (#10919)

[alamb]

This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/main by this push:
     new 0561057333 chore: cut down amount of zip benchmarks (#10919)
0561057333 is described below

commit 0561057333986dfa690ecb464fc6333e9c000c18
Author: Jeffrey Vo <jeffrey.vo.austra...@gmail.com>
AuthorDate: Thu Sep 3 21:23:47 2026 +0900

    chore: cut down amount of zip benchmarks (#10919)
    
    current zip_kernels benchmark has 378 benches, which seems overkill
    
    reducing down to 135 in this PR
---
 arrow/benches/zip_kernels.rs | 54 ++++----------------------------------------
 1 file changed, 4 insertions(+), 50 deletions(-)

diff --git a/arrow/benches/zip_kernels.rs b/arrow/benches/zip_kernels.rs
index 03f20214a8..ff828e148c 100644
--- a/arrow/benches/zip_kernels.rs
+++ b/arrow/benches/zip_kernels.rs
@@ -200,11 +200,6 @@ fn bench_zip_on_input_generator(c: &mut Criterion, 
input_generator: &impl InputG
     // Benchmarks for different scalar combinations
     for (description, truthy, falsy) in &[
         ("null_vs_non_null_scalar", &null_scalar, &non_null_scalar_1),
-        (
-            "non_null_scalar_vs_null_scalar",
-            &non_null_scalar_1,
-            &null_scalar,
-        ),
         ("non_nulls_scalars", &non_null_scalar_1, &non_null_scalar_2),
     ] {
         bench_zip_input_on_all_masks(
@@ -259,7 +254,6 @@ fn bench_zip_input_on_all_masks(
 }
 
 fn add_benchmark(c: &mut Criterion) {
-    // Primitive
     bench_zip_on_input_generator(
         c,
         &GeneratePrimitive::<Int32Type> {
@@ -268,51 +262,11 @@ fn add_benchmark(c: &mut Criterion) {
         },
     );
 
-    // Short strings
-    bench_zip_on_input_generator(
-        c,
-        &GenerateBytes::<GenericStringType<i32>> {
-            description: "short strings (3..10)".to_string(),
-            range_length: 3..10,
-            _marker: std::marker::PhantomData,
-        },
-    );
-
-    // Long strings
     bench_zip_on_input_generator(
         c,
         &GenerateBytes::<GenericStringType<i32>> {
-            description: "long strings (100..400)".to_string(),
-            range_length: 100..400,
-            _marker: std::marker::PhantomData,
-        },
-    );
-
-    // Short Bytes
-    bench_zip_on_input_generator(
-        c,
-        &GenerateBytes::<GenericBinaryType<i32>> {
-            description: "short bytes (3..10)".to_string(),
-            range_length: 3..10,
-            _marker: std::marker::PhantomData,
-        },
-    );
-
-    // Long Bytes
-    bench_zip_on_input_generator(
-        c,
-        &GenerateBytes::<GenericBinaryType<i32>> {
-            description: "long bytes (100..400)".to_string(),
-            range_length: 100..400,
-            _marker: std::marker::PhantomData,
-        },
-    );
-
-    bench_zip_on_input_generator(
-        c,
-        &GenerateStringView {
-            description: "string_views size (3..10)".to_string(),
-            range: 3..10,
+            description: "strings (3..20)".to_string(),
+            range_length: 3..20,
             _marker: std::marker::PhantomData,
         },
     );
@@ -320,8 +274,8 @@ fn add_benchmark(c: &mut Criterion) {
     bench_zip_on_input_generator(
         c,
         &GenerateStringView {
-            description: "string_views size (10..100)".to_string(),
-            range: 10..100,
+            description: "string_views size (3..20)".to_string(),
+            range: 3..20,
             _marker: std::marker::PhantomData,
         },
     );