This is an automated email from the ASF dual-hosted git repository.
thisisnic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new ce6fb9f5e2 GH-51152: [R] test-r-linux-as-cran nightly fails with NOTE
about non-standard top-level file jarl.toml (#51154)
ce6fb9f5e2 is described below
commit ce6fb9f5e2a81c9a12c22e95cd62d29923fbafc3
Author: Nic Crane <[email protected]>
AuthorDate: Thu Sep 3 15:58:51 2026 +0100
GH-51152: [R] test-r-linux-as-cran nightly fails with NOTE about
non-standard top-level file jarl.toml (#51154)
### Rationale for this change
The test-r-linux-as-cran nightly job has been failing since 2026-08-25
because `r/jarl.toml` (added in #50851) ends up in the package tarball and R
CMD check flags it as a non-standard top-level file.
### What changes are included in this PR?
Adds `jarl.toml` to `r/.Rbuildignore`, and removes the now-unused
`r/.lintr` config along with its `.Rbuildignore` and RAT exclude entries.
### Are these changes tested?
Checked locally that the `.Rbuildignore` pattern matches `jarl.toml`
without excluding anything else. The `test-r-linux-as-cran` crossbow job will
confirm the NOTE is gone.
### Are there any user-facing changes?
No.
* GitHub Issue: #51152
Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
---
dev/release/rat_exclude_files.txt | 1 -
r/.Rbuildignore | 2 +-
r/.lintr | 18 ------------------
3 files changed, 1 insertion(+), 20 deletions(-)
diff --git a/dev/release/rat_exclude_files.txt
b/dev/release/rat_exclude_files.txt
index db74b8066b..3c5518a959 100644
--- a/dev/release/rat_exclude_files.txt
+++ b/dev/release/rat_exclude_files.txt
@@ -80,7 +80,6 @@ requirements.txt
*.svg
*.devhelp2
*.scss
-r/.lintr
r/R/arrowExports.R
r/src/arrowExports.cpp
r/DESCRIPTION
diff --git a/r/.Rbuildignore b/r/.Rbuildignore
index 5e26108d39..87861e04e6 100644
--- a/r/.Rbuildignore
+++ b/r/.Rbuildignore
@@ -23,7 +23,7 @@ clang_format.sh
^.*\.Rhistory$
^extra-tests
STYLE.md
-^.lintr
+^jarl\.toml$
^.styler_excludes.R
^cheatsheet$
^revdep$
diff --git a/r/.lintr b/r/.lintr
deleted file mode 100644
index 6c1674689f..0000000000
--- a/r/.lintr
+++ /dev/null
@@ -1,18 +0,0 @@
-linters: linters_with_defaults(
- indentation_linter = NULL,
- line_length_linter = line_length_linter(120),
- object_name_linter = NULL,
- return_linter = NULL,
- # Even with a liberal definition of name styles, some of our names cause
issues due to `.`s for s3 classes or NA in the name
- # TODO: figure out if we con contribute to lintr to make these work
- # object_name_linter = object_name_linter(styles = c("snake_case",
"camelCase", "CamelCase", "symbols", "dotted.case", "UPPERCASE", "SNAKE_CASE")),
- object_length_linter = object_length_linter(40),
- object_usage_linter = NULL, # R6 methods are flagged,
- cyclocomp_linter = cyclocomp_linter(26) # TODO: reduce to default of 15
- # See also https://github.com/r-lib/lintr/issues/804 for cyclocomp issues
with R6
- )
-exclusions: list(
- "R/arrowExports.R",
- "R/dplyr-funcs-doc.R",
- "data-raw/codegen.R"
- )