This is an automated email from the ASF dual-hosted git repository.
thisisnic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 43751939f28 GH-51232: [CI] Remove the "take" comment bot for
self-assigning issues (#51233)
43751939f28 is described below
commit 43751939f285c6e972508942933580520fa39728
Author: Nic Crane <[email protected]>
AuthorDate: Thu Sep 17 15:22:31 2026 -0500
GH-51232: [CI] Remove the "take" comment bot for self-assigning issues
(#51233)
### Rationale for this change
Anyone could assign themselves an issue by commenting "take", including
issues already assigned to someone else. Assignment should be handled by
committers and collaborators instead.
### What changes are included in this PR?
Removes the `issue_assign` job from the comment bot workflow and updates
the contributor docs to say that a committer or collaborator will assign issues
on request.
### Are these changes tested?
No. Docs were checked with sphinx-lint via pre-commit.
### Are there any user-facing changes?
No. Contributors can no longer self-assign issues by commenting "take".
* GitHub Issue: #51232
Lead-authored-by: Nic Crane <[email protected]>
Co-authored-by: Copilot Autofix powered by AI
<[email protected]>
Signed-off-by: Nic Crane <[email protected]>
---
.github/workflows/comment_bot.yml | 18 ------------------
CONTRIBUTING.md | 3 ++-
docs/source/developers/bug_reports.rst | 6 ++++--
.../developers/guide/step_by_step/finding_issues.rst | 4 ++--
.../developers/guide/tutorials/python_tutorial.rst | 7 ++++---
docs/source/developers/reviewing.rst | 2 ++
6 files changed, 14 insertions(+), 26 deletions(-)
diff --git a/.github/workflows/comment_bot.yml
b/.github/workflows/comment_bot.yml
index ceff6c41d21..044c761aa63 100644
--- a/.github/workflows/comment_bot.yml
+++ b/.github/workflows/comment_bot.yml
@@ -56,21 +56,3 @@ jobs:
archery --debug trigger-bot \
--event-name "${GITHUB_EVENT_NAME}" \
--event-payload "${GITHUB_EVENT_PATH}"
-
- issue_assign:
- name: "Assign issue"
- permissions:
- issues: write
- if: github.event.comment.body == 'take'
- runs-on: ubuntu-latest
- steps:
- - uses: actions/github-script@v9
- with:
- github-token: ${{ secrets.GITHUB_TOKEN }}
- script: |
- github.rest.issues.addAssignees({
- owner: context.repo.owner,
- repo: context.repo.repo,
- issue_number: context.payload.issue.number,
- assignees: context.payload.comment.user.login
- });
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index f23c18f326b..d9a06e884d2 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -25,7 +25,8 @@ The Arrow project uses GitHub as a bug tracker. To report a
bug, sign in to
your GitHub account, navigate to [GitHub
issues](https://github.com/apache/arrow/issues)
and click on **New issue** .
-To be assigned to an issue, add a comment "take" to that issue.
+To be assigned to an issue, leave a comment on that issue saying you would
+like to work on it, and a committer or collaborator will assign it to you.
Before you create a new bug entry, we recommend you first search among existing
Arrow issues in
diff --git a/docs/source/developers/bug_reports.rst
b/docs/source/developers/bug_reports.rst
index 28bea77600c..1fcc0bb07e0 100644
--- a/docs/source/developers/bug_reports.rst
+++ b/docs/source/developers/bug_reports.rst
@@ -256,5 +256,7 @@ Issue assignment
++++++++++++++++
Assignment signals commitment to work on an issue, and contributors should
-self-assign issues when that work starts. Anyone can now self-assign issues
-by commenting ``take``.
+be assigned to issues when that work starts. If you would like to work on an
+issue, leave a comment saying so and a committer or collaborator will assign
+it to you. See :ref:`collaborators` for how to get the ability to assign
+issues yourself.
diff --git a/docs/source/developers/guide/step_by_step/finding_issues.rst
b/docs/source/developers/guide/step_by_step/finding_issues.rst
index de686269a88..0284f6e9308 100644
--- a/docs/source/developers/guide/step_by_step/finding_issues.rst
+++ b/docs/source/developers/guide/step_by_step/finding_issues.rst
@@ -79,8 +79,8 @@ in the comments.
When you find a GitHub issue you would like to work on, please mention
your interest in the comment section of that issue; that way we will know
- you are working on it.
- Consider assigning yourself to the issue (:ref:`issue-assignment`) when the
work starts.
+ you are working on it and can assign the issue to you
+ (see :ref:`issue-assignment`).
Also, do not hesitate to ask questions in the comment. You can get some
pointers about where to start and similar issues already solved.
diff --git a/docs/source/developers/guide/tutorials/python_tutorial.rst
b/docs/source/developers/guide/tutorials/python_tutorial.rst
index 3838acb9fcf..5b8256c8bd2 100644
--- a/docs/source/developers/guide/tutorials/python_tutorial.rst
+++ b/docs/source/developers/guide/tutorials/python_tutorial.rst
@@ -89,9 +89,10 @@ With a GitHub account created we will navigate to the
`GitHub issue dashboard <https://github.com/apache/arrow/issues>`_
and click on the **New issue** button.
-We should make sure to assign ourselves to the issue to let others
-know we are working on it. You can do that with adding a comment
-``take`` to the issue created.
+We should make sure to let others know we are working on the issue.
+You can do that by adding a comment to the issue created saying you
+would like to work on it, and a committer or collaborator will assign
+it to you.
.. seealso::
diff --git a/docs/source/developers/reviewing.rst
b/docs/source/developers/reviewing.rst
index 1550d6aa7ce..c0fcf56155d 100644
--- a/docs/source/developers/reviewing.rst
+++ b/docs/source/developers/reviewing.rst
@@ -296,6 +296,8 @@ In addition, we use the following labels to indicate
priority:
superset of issues marked "Critical Fix", as it also contains certain fixes
to issues causing errors and crashes.
+.. _collaborators:
+
Collaborators
=============
