This is an automated email from the ASF dual-hosted git repository.
Jefffrey pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/main by this push:
new 9e0ab287e9 fix(bug): `zip_kernels` benchmark not measured correctly
(#11217)
9e0ab287e9 is described below
commit 9e0ab287e9494891abe6f4cb45ce847886ede840
Author: WeblWabl <[email protected]>
AuthorDate: Fri Sep 25 11:16:20 2026 -0500
fix(bug): `zip_kernels` benchmark not measured correctly (#11217)
Currently we are only measuring the time it takes to throw an error for
array_vs_non_null_scalar benches in our zip kernels. This commit fixes
the input data to ensure we are actually measuring the benches on
success.
| Group | main | fixed | change |
|---|---|---|---|
| i32 array_vs_non_null_scalar | 16.6–17.3 ns | 1.44–70.0 µs | +8,400%
to +419,000% |
| i32 non_null_scalar_vs_array | 15.9–16.2 ns | 1.43–72.5 µs | +8,700%
to +452,000% |
| strings array_vs_non_null_scalar | 17.1–17.4 ns | 11.3–105.8 µs |
+65,900% to +612,000% |
| strings non_null_scalar_vs_array | 16.3–16.6 ns | 8.25–110.0 µs |
+50,200% to +664,000% |
| string_views, both groups | 16.3–17.3 ns | 9.43–98.7 µs | +54,700% to
+597,000% |
---
arrow/benches/zip_kernels.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arrow/benches/zip_kernels.rs b/arrow/benches/zip_kernels.rs
index ff828e148c..3d29baded3 100644
--- a/arrow/benches/zip_kernels.rs
+++ b/arrow/benches/zip_kernels.rs
@@ -216,14 +216,14 @@ fn bench_zip_on_input_generator(c: &mut Criterion,
input_generator: &impl InputG
&mut group,
&masks,
&array_1_10pct_nulls,
- &non_null_scalar_1,
+ &Scalar::new(non_null_scalar_1.clone()),
);
bench_zip_input_on_all_masks(
"non_null_scalar_vs_array",
&mut group,
&masks,
- &non_null_scalar_1,
+ &Scalar::new(non_null_scalar_1.clone()),
&array_1_10pct_nulls,
);
