This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git


The following commit(s) were added to refs/heads/main by this push:
     new f1378d664b ci: replace Windows cmd shell with PowerShell (#4812)
f1378d664b is described below

commit f1378d664b61ce65f25a54c3b863aa62ea9d2480
Author: Efe <[email protected]>
AuthorDate: Mon Sep 28 07:51:40 2026 +0300

    ci: replace Windows cmd shell with PowerShell (#4812)
    
    ## What's Changed
    
    Replace the Windows driver-manager workflow step's `cmd.exe` shell with
    PowerShell.
    
    Closes #4269.
    
    AI assistance was used during development; the complete diff and test
    results were reviewed by the author.
    
    Signed-off-by: Efe Gökdemir <[email protected]>
---
 .github/workflows/java.yml | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/java.yml b/.github/workflows/java.yml
index 99af592bd8..4ece11eb45 100644
--- a/.github/workflows/java.yml
+++ b/.github/workflows/java.yml
@@ -176,11 +176,23 @@ jobs:
       # I think static and shared conflict on Windows so build static 
separately
       - name: Build driver manager (Windows)
         if: matrix.os == 'Windows'
-        # TODO(https://github.com/apache/arrow-adbc/issues/4269): remove 
cmd.exe usage
-        shell: cmd # zizmor: ignore[misfeature]
+        shell: pwsh
         run: |
-          cmake -G "Visual Studio 18 2026" -A x64 -DADBC_BUILD_SHARED=OFF 
-DADBC_BUILD_STATIC=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DADBC_DRIVER_MANAGER=ON 
-DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=%cd%\build\${{ 
matrix.vcpkg_arch }} -B %cd%\buildmanager %cd%\c || exit /B 1
-          cmake --build %cd%\buildmanager --config Debug --target install 
--verbose -j || exit /B 1
+          $buildDir = Join-Path $PWD.Path 'buildmanager'
+          $installPrefix = Join-Path $PWD.Path 'build/${{ matrix.vcpkg_arch }}'
+          $sourceDir = Join-Path $PWD.Path 'c'
+          cmake -G 'Visual Studio 18 2026' -A x64 `
+            '-DADBC_BUILD_SHARED=OFF' `
+            '-DADBC_BUILD_STATIC=ON' `
+            '-DCMAKE_VERBOSE_MAKEFILE=ON' `
+            '-DADBC_DRIVER_MANAGER=ON' `
+            '-DCMAKE_BUILD_TYPE=RelWithDebInfo' `
+            "-DCMAKE_INSTALL_PREFIX=$installPrefix" `
+            -B $buildDir `
+            $sourceDir
+          if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
+          cmake --build $buildDir --config Debug --target install --verbose -j
+          if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
 
       - name: Build JNI artifacts
         run: |

Reply via email to