This is an automated email from the ASF dual-hosted git repository. kbhatt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/atlas.git
The following commit(s) were added to refs/heads/master by this push: new ba1b40f ATLAS-3909: UI: Improve readability for the table view in the entity detail page ba1b40f is described below commit ba1b40f0426e5ff0e621eab5184d916a6f506f59 Author: kevalbhatt <kbh...@apache.org> AuthorDate: Mon Aug 3 17:22:36 2020 +0530 ATLAS-3909: UI: Improve readability for the table view in the entity detail page --- dashboardv2/public/css/scss/table.scss | 4 ++++ .../js/templates/entity/EntityDetailTableLayoutView_tmpl.html | 2 +- .../public/js/templates/entity/EntityUserDefineView_tmpl.html | 2 +- dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html | 8 +------- .../public/js/templates/graph/RelationshipLayoutView_tmpl.html | 2 +- dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js | 2 +- dashboardv3/public/css/scss/table.scss | 4 ++++ dashboardv3/public/css/scss/theme.scss | 2 +- .../js/templates/entity/EntityDetailTableLayoutView_tmpl.html | 2 +- .../public/js/templates/entity/EntityUserDefineView_tmpl.html | 2 +- dashboardv3/public/js/templates/graph/LineageLayoutView_tmpl.html | 8 +------- .../public/js/templates/graph/RelationshipLayoutView_tmpl.html | 2 +- dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js | 2 +- 13 files changed, 19 insertions(+), 23 deletions(-) diff --git a/dashboardv2/public/css/scss/table.scss b/dashboardv2/public/css/scss/table.scss index 669bcfc..519d083 100644 --- a/dashboardv2/public/css/scss/table.scss +++ b/dashboardv2/public/css/scss/table.scss @@ -14,6 +14,10 @@ // See the License for the specific language governing permissions and // limitations under the License. +.table.bold-key>tbody>tr>td:first-child { + font-weight: 600; +} + tr.empty { td { display: table-cell; diff --git a/dashboardv2/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html b/dashboardv2/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html index cdceb77..3fe0e95 100644 --- a/dashboardv2/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html +++ b/dashboardv2/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html @@ -38,7 +38,7 @@ <div id="collapse1" class="panel-collapse collapse in"> <div class="panel-body"> <div class="entity-detail-table"> - <table class="table"> + <table class="table bold-key"> <tbody data-id="detailValue" class="hide-empty-value"> </tbody> </table> diff --git a/dashboardv2/public/js/templates/entity/EntityUserDefineView_tmpl.html b/dashboardv2/public/js/templates/entity/EntityUserDefineView_tmpl.html index 074d39b..d1a9128 100644 --- a/dashboardv2/public/js/templates/entity/EntityUserDefineView_tmpl.html +++ b/dashboardv2/public/js/templates/entity/EntityUserDefineView_tmpl.html @@ -75,7 +75,7 @@ <div id="r_entityUserDefinedItemView"></div> {{else}} <div class="entity-detail-table"> - <table class="table"> + <table class="table bold-key"> <tbody> {{#each customAttibutes}} <tr> diff --git a/dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html b/dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html index 8679c3b..38697e3 100644 --- a/dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html +++ b/dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html @@ -123,13 +123,7 @@ <span data-id="box-close" class="btn btn-sm btn-close lineage-node-detail-close"><i class="fa fa-close"></i></span> </div> <div class="body"> - <table class='table table-quickMenu'> - <thead> - <tr> - <th>Key</th> - <th>Value</th> - </tr> - </thead> + <table class='table bold-key'> <tbody data-id="nodeDetailTable"></tbody> </table> </div> diff --git a/dashboardv2/public/js/templates/graph/RelationshipLayoutView_tmpl.html b/dashboardv2/public/js/templates/graph/RelationshipLayoutView_tmpl.html index 47aaad7..acf9bb3 100644 --- a/dashboardv2/public/js/templates/graph/RelationshipLayoutView_tmpl.html +++ b/dashboardv2/public/js/templates/graph/RelationshipLayoutView_tmpl.html @@ -61,7 +61,7 @@ </div> </div> </div> - <table class="table table-quickMenu" data-id="relationshipDetailTable"> + <table class="table table-quickMenu bold-key" data-id="relationshipDetailTable"> <thead> <tr> <th>Key</th> diff --git a/dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js b/dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js index 5e4643e..2b4ec8f 100644 --- a/dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js +++ b/dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js @@ -262,7 +262,7 @@ define([ '<div class="btn-group pull-left"> <button type="button" title="Collapse"><i class="ec-icon fa"></i></button></div>' + '</div>' + '<div id="' + _.escape(obj.get("__internal_UI_businessMetadataName")) + '" class="panel-collapse collapse in">' + - '<div class="panel-body"><table class="table">' + tableBody + '</table></div>' + + '<div class="panel-body"><table class="table bold-key">' + tableBody + '</table></div>' + '</div></div>'; }, onRender: function() { diff --git a/dashboardv3/public/css/scss/table.scss b/dashboardv3/public/css/scss/table.scss index 669bcfc..519d083 100644 --- a/dashboardv3/public/css/scss/table.scss +++ b/dashboardv3/public/css/scss/table.scss @@ -14,6 +14,10 @@ // See the License for the specific language governing permissions and // limitations under the License. +.table.bold-key>tbody>tr>td:first-child { + font-weight: 600; +} + tr.empty { td { display: table-cell; diff --git a/dashboardv3/public/css/scss/theme.scss b/dashboardv3/public/css/scss/theme.scss index abbde7a..af9c23d 100644 --- a/dashboardv3/public/css/scss/theme.scss +++ b/dashboardv3/public/css/scss/theme.scss @@ -131,7 +131,7 @@ header.atlas-header { border-bottom: 1px $color_mystic_approx solid; position: fixed; width: 100%; - z-index: 3; + z-index: 4; box-shadow: 0px 2px 6px 0px rgba(0, 0, 0, 0.05); .navbar-nav { diff --git a/dashboardv3/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html b/dashboardv3/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html index cdceb77..3fe0e95 100644 --- a/dashboardv3/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html +++ b/dashboardv3/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html @@ -38,7 +38,7 @@ <div id="collapse1" class="panel-collapse collapse in"> <div class="panel-body"> <div class="entity-detail-table"> - <table class="table"> + <table class="table bold-key"> <tbody data-id="detailValue" class="hide-empty-value"> </tbody> </table> diff --git a/dashboardv3/public/js/templates/entity/EntityUserDefineView_tmpl.html b/dashboardv3/public/js/templates/entity/EntityUserDefineView_tmpl.html index 074d39b..d1a9128 100644 --- a/dashboardv3/public/js/templates/entity/EntityUserDefineView_tmpl.html +++ b/dashboardv3/public/js/templates/entity/EntityUserDefineView_tmpl.html @@ -75,7 +75,7 @@ <div id="r_entityUserDefinedItemView"></div> {{else}} <div class="entity-detail-table"> - <table class="table"> + <table class="table bold-key"> <tbody> {{#each customAttibutes}} <tr> diff --git a/dashboardv3/public/js/templates/graph/LineageLayoutView_tmpl.html b/dashboardv3/public/js/templates/graph/LineageLayoutView_tmpl.html index 8679c3b..38697e3 100644 --- a/dashboardv3/public/js/templates/graph/LineageLayoutView_tmpl.html +++ b/dashboardv3/public/js/templates/graph/LineageLayoutView_tmpl.html @@ -123,13 +123,7 @@ <span data-id="box-close" class="btn btn-sm btn-close lineage-node-detail-close"><i class="fa fa-close"></i></span> </div> <div class="body"> - <table class='table table-quickMenu'> - <thead> - <tr> - <th>Key</th> - <th>Value</th> - </tr> - </thead> + <table class='table bold-key'> <tbody data-id="nodeDetailTable"></tbody> </table> </div> diff --git a/dashboardv3/public/js/templates/graph/RelationshipLayoutView_tmpl.html b/dashboardv3/public/js/templates/graph/RelationshipLayoutView_tmpl.html index 74b30a3..ab14138 100644 --- a/dashboardv3/public/js/templates/graph/RelationshipLayoutView_tmpl.html +++ b/dashboardv3/public/js/templates/graph/RelationshipLayoutView_tmpl.html @@ -62,7 +62,7 @@ </div> </div> </div> - <table class="table table-quickMenu" data-id="relationshipDetailTable"> + <table class="table table-quickMenu bold-key" data-id="relationshipDetailTable"> <thead> <tr> <th>Key</th> diff --git a/dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js b/dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js index 5e4643e..2b4ec8f 100644 --- a/dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js +++ b/dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js @@ -262,7 +262,7 @@ define([ '<div class="btn-group pull-left"> <button type="button" title="Collapse"><i class="ec-icon fa"></i></button></div>' + '</div>' + '<div id="' + _.escape(obj.get("__internal_UI_businessMetadataName")) + '" class="panel-collapse collapse in">' + - '<div class="panel-body"><table class="table">' + tableBody + '</table></div>' + + '<div class="panel-body"><table class="table bold-key">' + tableBody + '</table></div>' + '</div></div>'; }, onRender: function() {