This is an automated email from the ASF dual-hosted git repository.
chaitalithombare pushed a commit to branch atlas-2.5
in repository https://gitbox.apache.org/repos/asf/atlas.git
The following commit(s) were added to refs/heads/atlas-2.5 by this push:
new 4cbb482e1 ATLAS-5017: Patch to replace the long strings set in
spark_process attributes (#337) (cherry picked from commit
25e35e699d2e3a6c7b9974a1aa0140f6cd9a9076) Co-authored-by: chaitalithombare
<[email protected]>
4cbb482e1 is described below
commit 4cbb482e1039f154173d961adee2ea2a484c5696
Author: chaitalicod <[email protected]>
AuthorDate: Mon Jun 9 12:11:36 2025 +0530
ATLAS-5017: Patch to replace the long strings set in spark_process
attributes (#337)
(cherry picked from commit 25e35e699d2e3a6c7b9974a1aa0140f6cd9a9076)
Co-authored-by: chaitalithombare <[email protected]>
---
.../java/org/apache/atlas/AtlasConfiguration.java | 4 +-
.../repository/patches/AtlasPatchManager.java | 1 +
.../ReplaceHugeSparkProcessAttributesPatch.java | 108 +++++++++++++++++++++
3 files changed, 111 insertions(+), 2 deletions(-)
diff --git a/intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
b/intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
index cc95f19be..f8de7c524 100644
--- a/intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
+++ b/intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
@@ -115,8 +115,8 @@ public enum AtlasConfiguration {
UI_TASKS_TAB_USE_ENABLED("atlas.tasks.ui.tab.enabled", false),
ATLAS_ASYNC_IMPORT_MIN_DURATION_OVERRIDE_TEST_AUTOMATION("atlas.async.import.min.duration.override.test.automation",
false),
ASYNC_IMPORT_TOPIC_PREFIX("atlas.async.import.topic.prefix",
"ATLAS_IMPORT_"),
- ASYNC_IMPORT_REQUEST_ID_PREFIX("atlas.async.import.request_id.prefix",
"async_import_");
-
+ ASYNC_IMPORT_REQUEST_ID_PREFIX("atlas.async.import.request_id.prefix",
"async_import_"),
+
REPLACE_HUGE_SPARK_PROCESS_ATTRIBUTES_PATCH("atlas.process.spark.attributes.update.patch",
false);
private static final Configuration APPLICATION_PROPERTIES;
private final String propertyName;
diff --git
a/repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
b/repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
index 0f7c5309c..30d3b894c 100644
---
a/repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
+++
b/repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
@@ -111,6 +111,7 @@ public class AtlasPatchManager {
handlers.add(new UpdateCompositeIndexStatusPatch(context));
handlers.add(new RelationshipTypeNamePatch(context));
handlers.add(new ProcessImpalaNamePatch(context));
+ handlers.add(new ReplaceHugeSparkProcessAttributesPatch(context));
LOG.info("<== AtlasPatchManager.init()");
}
diff --git
a/repository/src/main/java/org/apache/atlas/repository/patches/ReplaceHugeSparkProcessAttributesPatch.java
b/repository/src/main/java/org/apache/atlas/repository/patches/ReplaceHugeSparkProcessAttributesPatch.java
new file mode 100644
index 000000000..10938f1e9
--- /dev/null
+++
b/repository/src/main/java/org/apache/atlas/repository/patches/ReplaceHugeSparkProcessAttributesPatch.java
@@ -0,0 +1,108 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.atlas.repository.patches;
+
+import org.apache.atlas.AtlasConfiguration;
+import org.apache.atlas.exception.AtlasBaseException;
+import org.apache.atlas.pc.WorkItemManager;
+import org.apache.atlas.repository.Constants;
+import org.apache.atlas.repository.graphdb.AtlasGraph;
+import org.apache.atlas.repository.graphdb.AtlasVertex;
+import org.apache.atlas.type.AtlasEntityType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Iterator;
+
+import static org.apache.atlas.model.patches.AtlasPatch.PatchStatus.APPLIED;
+
+public class ReplaceHugeSparkProcessAttributesPatch extends AtlasPatchHandler {
+ private static final Logger LOG =
LoggerFactory.getLogger(ReplaceHugeSparkProcessAttributesPatch.class);
+
+ private static final String PATCH_ID = "JAVA_PATCH_0000_015";
+ private static final String PATCH_DESCRIPTION = "Replace attributes
details and sparkPlanDescription to null";
+
+ private final PatchContext context;
+
+ public ReplaceHugeSparkProcessAttributesPatch(PatchContext context) {
+ super(context.getPatchRegistry(), PATCH_ID, PATCH_DESCRIPTION);
+
+ this.context = context;
+ }
+
+ @Override
+ public void apply() throws AtlasBaseException {
+ if
(AtlasConfiguration.REPLACE_HUGE_SPARK_PROCESS_ATTRIBUTES_PATCH.getBoolean() ==
false) {
+ LOG.info("ReplaceHugeSparkProcessAttributesPatch: Skipped, since
not enabled!");
+ return;
+ }
+ ConcurrentPatchProcessor patchProcessor = new
ReplaceHugeSparkProcessAttributesPatchProcessor(context);
+
+ patchProcessor.apply();
+
+ setStatus(APPLIED);
+
+ LOG.info("ReplaceHugeSparkProcessAttributesPatch.apply(): patchId={},
status={}", getPatchId(), getStatus());
+ }
+
+ public static class ReplaceHugeSparkProcessAttributesPatchProcessor
extends ConcurrentPatchProcessor {
+ private static final String TYPE_NAME_SPARK_PROCESS = "spark_process";
+ private static final String ATTR_NAME_DETAILS = "details";
+ private static final String ATTR_NAME_SPARKPLANDESCRIPTION =
"sparkPlanDescription";
+
+ public ReplaceHugeSparkProcessAttributesPatchProcessor(PatchContext
context) {
+ super(context);
+ }
+
+ @Override
+ protected void prepareForExecution() {
+ }
+
+ @Override
+ public void submitVerticesToUpdate(WorkItemManager manager) {
+ AtlasGraph graph = getGraph();
+ Iterable<Object> iterable =
graph.query().has(Constants.ENTITY_TYPE_PROPERTY_KEY,
TYPE_NAME_SPARK_PROCESS).vertexIds();
+ int count = 0;
+
+ for (Iterator<Object> iter = iterable.iterator(); iter.hasNext();
) {
+ Object vertexId = iter.next();
+
+ manager.checkProduce(vertexId);
+
+ count++;
+ }
+
+ LOG.info("found {} entities of type {}", count,
TYPE_NAME_SPARK_PROCESS);
+ }
+
+ @Override
+ protected void processVertexItem(Long vertexId, AtlasVertex vertex,
String typeName, AtlasEntityType entityType) {
+ LOG.debug("processItem(typeName={}, vertexId={})", typeName,
vertexId);
+
+ try {
+
vertex.removeProperty(entityType.getVertexPropertyName(ATTR_NAME_DETAILS));
+
vertex.removeProperty(entityType.getVertexPropertyName(ATTR_NAME_SPARKPLANDESCRIPTION));
+ } catch (Exception e) {
+ LOG.error("Error updating: {}", vertexId, e);
+ }
+
+ LOG.debug("processItem(typeName={}, vertexId={}): Done!",
typeName, vertexId);
+ }
+ }
+}
