x-tong commented on code in PR #2086: URL: https://github.com/apache/auron/pull/2086#discussion_r2940501875
########## auron-flink-extension/auron-flink-runtime/src/main/java/org/apache/auron/flink/arrow/writers/ArrayWriter.java: ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.auron.flink.arrow.writers; + +import java.util.Objects; +import org.apache.arrow.vector.complex.ListVector; +import org.apache.flink.table.data.ArrayData; +import org.apache.flink.table.data.RowData; + +/** + * {@link ArrowFieldWriter} for arrays ({@link ListVector}). + * + * <p>Holds an {@code elementWriter} that writes each array element. The element writer operates on + * {@link ArrayData} since array elements are accessed via {@link ArrayData} interface. + * + * @param <T> the input data type + */ +public abstract class ArrayWriter<T> extends ArrowFieldWriter<T> { + + /** Creates an ArrayWriter that reads from {@link RowData}. */ + public static ArrayWriter<RowData> forRow(ListVector listVector, ArrowFieldWriter<ArrayData> elementWriter) { + return new ArrayWriterForRow(listVector, elementWriter); + } + + /** Creates an ArrayWriter that reads from {@link ArrayData}. */ + public static ArrayWriter<ArrayData> forArray(ListVector listVector, ArrowFieldWriter<ArrayData> elementWriter) { + return new ArrayWriterForArray(listVector, elementWriter); + } + + // ------------------------------------------------------------------------------------------ + + private final ArrowFieldWriter<ArrayData> elementWriter; + + private ArrayWriter(ListVector listVector, ArrowFieldWriter<ArrayData> elementWriter) { + super(listVector); + this.elementWriter = Objects.requireNonNull(elementWriter); + } + + abstract boolean isNullAt(T in, int ordinal); + + abstract ArrayData readArray(T in, int ordinal); + + @Override + public void doWrite(T in, int ordinal) { + if (!isNullAt(in, ordinal)) { + ((ListVector) getValueVector()).startNewValue(getCount()); + ArrayData array = readArray(in, ordinal); + for (int i = 0; i < array.size(); i++) { Review Comment: This is intentional and consistent with the Flink official implementation in `flink-python` ([ArrowArrayWriter.java](https://github.com/apache/flink/blob/master/flink-python/src/main/java/org/apache/flink/python/util/ProtoUtils.java)). The upstream `ArrayWriter` also omits explicit `setNull` for null entries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
