Copilot commented on code in PR #2127:
URL: https://github.com/apache/auron/pull/2127#discussion_r3005649021
##########
spark-extension-shims-spark/src/test/scala/org/apache/auron/AuronFunctionSuite.scala:
##########
@@ -117,6 +117,14 @@ class AuronFunctionSuite extends AuronQueryTest with
BaseAuronSQLSuite {
}
}
+ test("ascii function") {
+ withTable("t1") {
+ sql("create table t1(c1 string) using parquet")
+ sql("insert into t1 values('Auron'), (''), (null)")
Review Comment:
The regression test only exercises pure-ASCII, empty string, and null. Since
`ascii()` semantics can differ between engines for non-ASCII/multibyte UTF-8
input, consider adding at least one non-ASCII value (e.g., 'éclair' or '你') to
ensure the native backend matches Spark for those cases too (and prevents
future regressions).
```suggestion
sql("insert into t1 values('Auron'), (''), (null), ('éclair'), ('你')")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
