weiqingy commented on issue #1856:
URL: https://github.com/apache/auron/issues/1856#issuecomment-4159939649
Thanks @Tartarus0zm for the quick confirmation!
I've updated the design doc to Rev 3 incorporating both points:
Q1 — PhysicalExprNode return type: FlinkNodeConverter<T> now returns
PhysicalExprNode. This aligns with Spark's NativeConverters.convertExpr() and
convertAggregateExpr() which both return PhysicalExprNode. In auron.proto,
PhysicalAggExprNode is a variant within PhysicalExprNode, so the return type is
uniform across all converter sub-interfaces.
Q2 — Sub-interfaces in scope: The design now includes five classes:
```
┌───────────────────────────┬───────────────────────────────────────────────────────────┐
│ Class │ Role
│
├───────────────────────────┼───────────────────────────────────────────────────────────┤
│ FlinkNodeConverter<T> │ Generic base interface
│
├───────────────────────────┼───────────────────────────────────────────────────────────┤
│ FlinkRexNodeConverter │ Sub-interface: RexNode → PhysicalExprNode
│
├───────────────────────────┼───────────────────────────────────────────────────────────┤
│ FlinkAggCallConverter │ Sub-interface: AggregateCall →
PhysicalExprNode │
├───────────────────────────┼───────────────────────────────────────────────────────────┤
│ FlinkNodeConverterFactory │ Singleton with separate rexConverterMap +
aggConverterMap │
├───────────────────────────┼───────────────────────────────────────────────────────────┤
│ ConverterContext │ Shared state (unchanged)
│
└───────────────────────────┴───────────────────────────────────────────────────────────┘
```
Updated doc:
https://github.com/weiqingy/auron/blob/AURON-1856-design/docs/PR-AURON-1856/AURON-1856-DESIGN.md
If this looks good, I'll move forward with implementation. Let me know if
you have any further feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
