[avro] branch master updated: AVRO-3134: Fix ArgumentOutOfRangeException in method ToString of AvroDecimal

[dkulp]

This is an automated email from the ASF dual-hosted git repository.

dkulp pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/avro.git


The following commit(s) were added to refs/heads/master by this push:
     new fe40576  AVRO-3134: Fix ArgumentOutOfRangeException in method ToString 
of AvroDecimal
fe40576 is described below

commit fe40576cd22e93776e7e48302f4d3358b0b4a4e3
Author: Thiago Froes <tf.fr...@gmail.com>
AuthorDate: Sat May 8 19:27:24 2021 -0300

    AVRO-3134: Fix ArgumentOutOfRangeException in method ToString of AvroDecimal
    
    The method ToString of class AvroDecimal causes ArgumentOutOfRangeException
    when Scale is greater than Unscaled number size.
    The method ToString of class AvroDecimal returns a wrong result when Scale
    is equal to the Unscaled number size because is missing a "0"
---
 lang/csharp/src/apache/main/AvroDecimal.cs     |  2 +-
 lang/csharp/src/apache/test/AvroDecimalTest.cs | 46 ++++++++++++++++++++++++++
 2 files changed, 47 insertions(+), 1 deletion(-)

diff --git a/lang/csharp/src/apache/main/AvroDecimal.cs 
b/lang/csharp/src/apache/main/AvroDecimal.cs
index 0ab0f05..17d1120 100644
--- a/lang/csharp/src/apache/main/AvroDecimal.cs
+++ b/lang/csharp/src/apache/main/AvroDecimal.cs
@@ -132,7 +132,7 @@ namespace Avro
         /// <returns>A string representation of the numeric value.</returns>
         public override string ToString()
         {
-            var number = UnscaledValue.ToString(CultureInfo.CurrentCulture);
+            var number = UnscaledValue.ToString($"D{Scale + 1}", 
CultureInfo.CurrentCulture);
 
             if (Scale > 0)
                 return number.Insert(number.Length - Scale, 
CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator);
diff --git a/lang/csharp/src/apache/test/AvroDecimalTest.cs 
b/lang/csharp/src/apache/test/AvroDecimalTest.cs
new file mode 100644
index 0000000..e10210b
--- /dev/null
+++ b/lang/csharp/src/apache/test/AvroDecimalTest.cs
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using NUnit.Framework;
+
+namespace Avro.test
+{
+    [TestFixture]
+    class AvroDecimalTest
+    {
+        [TestCase(1)]
+        [TestCase(1000)]
+        [TestCase(10.10)]
+        [TestCase(0)]
+        [TestCase(0.1)]
+        [TestCase(0.01)]
+        [TestCase(-1)]
+        [TestCase(-1000)]
+        [TestCase(-10.10)]
+        [TestCase(-0.1)]
+        [TestCase(-0.01)]
+        public void TestAvroDecimalToString(decimal value)
+        {
+            var valueString = value.ToString();
+
+            var avroDecimal = new AvroDecimal(value);            
+            var avroDecimalString = avroDecimal.ToString();
+
+            Assert.AreEqual(valueString, avroDecimalString);
+        }
+    }
+}