This is an automated email from the ASF dual-hosted git repository. eskabetxe pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bahir-flink.git
commit 73a4fbd7372fbf01b5bcbc4a2ccb36a7011df8fa Author: min <[email protected]> AuthorDate: Thu May 19 19:17:40 2022 +0800 fix: reformat code style --- .../connector/convertor/RowResultConvertor.java | 1 - .../connector/convertor/RowResultRowConvertor.java | 1 - .../kudu/connector/reader/KuduReaderIterator.java | 3 --- .../connectors/kudu/format/KuduRowInputFormat.java | 12 ++++++---- .../kudu/table/dynamic/KuduDynamicTableSink.java | 15 +++++++----- .../kudu/table/dynamic/KuduDynamicTableSource.java | 4 ++-- .../dynamic/KuduDynamicTableSourceSinkFactory.java | 2 -- .../table/dynamic/catalog/KuduCatalogFactory.java | 3 --- .../lookup/AbstractKuduLookupFunction.java | 1 - .../table/function/lookup/KuduLookupOptions.java | 2 +- .../function/lookup/KuduRowDataLookupFunction.java | 1 - .../kudu/table/utils/KuduTableUtils.java | 28 ++++++++-------------- .../kudu/table/KuduTableSourceITCase.java | 3 --- .../kudu/table/dynamic/KuduDynamicSinkTest.java | 12 +++------- .../kudu/table/dynamic/KuduDynamicSourceTest.java | 2 +- .../dynamic/KuduRowDataLookupFunctionTest.java | 2 +- .../writer/RowDataUpsertOperationMapperTest.java | 13 +--------- 17 files changed, 35 insertions(+), 70 deletions(-) diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/convertor/RowResultConvertor.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/convertor/RowResultConvertor.java index f7cca84..ee71b3c 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/convertor/RowResultConvertor.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/convertor/RowResultConvertor.java @@ -14,7 +14,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.flink.connectors.kudu.connector.convertor; import org.apache.flink.annotation.Internal; diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/convertor/RowResultRowConvertor.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/convertor/RowResultRowConvertor.java index 1146d49..be9b448 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/convertor/RowResultRowConvertor.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/convertor/RowResultRowConvertor.java @@ -14,7 +14,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.flink.connectors.kudu.connector.convertor; import org.apache.flink.annotation.Internal; diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/reader/KuduReaderIterator.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/reader/KuduReaderIterator.java index f31e959..543e41e 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/reader/KuduReaderIterator.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/reader/KuduReaderIterator.java @@ -18,9 +18,6 @@ package org.apache.flink.connectors.kudu.connector.reader; import org.apache.flink.annotation.Internal; import org.apache.flink.connectors.kudu.connector.convertor.RowResultConvertor; -import org.apache.flink.types.Row; - -import org.apache.kudu.Schema; import org.apache.kudu.client.KuduException; import org.apache.kudu.client.KuduScanner; import org.apache.kudu.client.RowResult; diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/format/KuduRowInputFormat.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/format/KuduRowInputFormat.java index 99b5155..f7e5bf9 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/format/KuduRowInputFormat.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/format/KuduRowInputFormat.java @@ -26,23 +26,25 @@ import org.apache.flink.types.Row; import java.util.List; -import static org.apache.flink.util.Preconditions.checkNotNull; - /** * InputFormat based on the row object type */ @PublicEvolving public class KuduRowInputFormat extends AbstractKuduInputFormat<Row> { - public KuduRowInputFormat(KuduReaderConfig readerConfig, RowResultConvertor<Row> rowResultConvertor, KuduTableInfo tableInfo) { + public KuduRowInputFormat(KuduReaderConfig readerConfig, RowResultConvertor<Row> rowResultConvertor, + KuduTableInfo tableInfo) { super(readerConfig, rowResultConvertor, tableInfo); } - public KuduRowInputFormat(KuduReaderConfig readerConfig, RowResultConvertor<Row> rowResultConvertor, KuduTableInfo tableInfo, List<String> tableProjections) { + public KuduRowInputFormat(KuduReaderConfig readerConfig, RowResultConvertor<Row> rowResultConvertor, + KuduTableInfo tableInfo, List<String> tableProjections) { super(readerConfig, rowResultConvertor, tableInfo, tableProjections); } - public KuduRowInputFormat(KuduReaderConfig readerConfig, RowResultConvertor<Row> rowResultConvertor, KuduTableInfo tableInfo, List<KuduFilterInfo> tableFilters, List<String> tableProjections) { + public KuduRowInputFormat(KuduReaderConfig readerConfig, RowResultConvertor<Row> rowResultConvertor, + KuduTableInfo tableInfo, List<KuduFilterInfo> tableFilters, + List<String> tableProjections) { super(readerConfig, rowResultConvertor, tableInfo, tableFilters, tableProjections); } diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSink.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSink.java index 6237c94..179c01f 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSink.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSink.java @@ -14,7 +14,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.flink.connectors.kudu.table.dynamic; import org.apache.flink.connectors.kudu.connector.KuduTableInfo; @@ -25,20 +24,22 @@ import org.apache.flink.table.api.TableSchema; import org.apache.flink.table.connector.ChangelogMode; import org.apache.flink.table.connector.sink.DynamicTableSink; import org.apache.flink.table.connector.sink.SinkFunctionProvider; -import org.apache.flink.table.connector.source.DynamicTableSource; import org.apache.flink.table.data.RowData; import org.apache.flink.types.RowKind; import org.apache.flink.util.Preconditions; import java.util.Objects; -/** A {@link KuduDynamicTableSink} for Kudu. */ +/** + * A {@link KuduDynamicTableSink} for Kudu. + */ public class KuduDynamicTableSink implements DynamicTableSink { private final KuduWriterConfig.Builder writerConfigBuilder; private final TableSchema flinkSchema; private final KuduTableInfo tableInfo; - public KuduDynamicTableSink(KuduWriterConfig.Builder writerConfigBuilder, TableSchema flinkSchema, KuduTableInfo tableInfo) { + public KuduDynamicTableSink(KuduWriterConfig.Builder writerConfigBuilder, TableSchema flinkSchema, + KuduTableInfo tableInfo) { this.writerConfigBuilder = writerConfigBuilder; this.flinkSchema = flinkSchema; this.tableInfo = tableInfo; @@ -56,7 +57,8 @@ public class KuduDynamicTableSink implements DynamicTableSink { @Override public SinkRuntimeProvider getSinkRuntimeProvider(Context context) { - KuduSink<RowData> upsertKuduSink = new KuduSink<>(writerConfigBuilder.build(), tableInfo, new RowDataUpsertOperationMapper(flinkSchema)); + KuduSink<RowData> upsertKuduSink = new KuduSink<>(writerConfigBuilder.build(), tableInfo, + new RowDataUpsertOperationMapper(flinkSchema)); return SinkFunctionProvider.of(upsertKuduSink); } @@ -75,7 +77,8 @@ public class KuduDynamicTableSink implements DynamicTableSink { if (this == o) return true; if (o == null || getClass() != o.getClass()) return false; KuduDynamicTableSink that = (KuduDynamicTableSink) o; - return Objects.equals(writerConfigBuilder, that.writerConfigBuilder) && Objects.equals(flinkSchema, that.flinkSchema) && Objects.equals(tableInfo, that.tableInfo); + return Objects.equals(writerConfigBuilder, that.writerConfigBuilder) && Objects.equals(flinkSchema, + that.flinkSchema) && Objects.equals(tableInfo, that.tableInfo); } @Override diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSource.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSource.java index b576ccb..2022cd7 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSource.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSource.java @@ -154,8 +154,8 @@ public class KuduDynamicTableSource implements ScanTableSource, SupportsProjecti @Override public int hashCode() { - int result = Objects.hash(configBuilder, tableInfo, physicalSchema, kuduLookupOptions, kuduRowDataInputFormat - , filters, predicates); + int result = Objects.hash(configBuilder, tableInfo, physicalSchema, + kuduLookupOptions, kuduRowDataInputFormat, filters, predicates); result = 31 * result + Arrays.hashCode(projectedFields); return result; } diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSourceSinkFactory.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSourceSinkFactory.java index e8f4f7b..973a81e 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSourceSinkFactory.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSourceSinkFactory.java @@ -22,8 +22,6 @@ import org.apache.flink.configuration.ReadableConfig; import org.apache.flink.connectors.kudu.connector.KuduTableInfo; import org.apache.flink.connectors.kudu.connector.reader.KuduReaderConfig; import org.apache.flink.connectors.kudu.connector.writer.KuduWriterConfig; -import org.apache.flink.connectors.kudu.table.dynamic.KuduDynamicTableSink; -import org.apache.flink.connectors.kudu.table.dynamic.KuduDynamicTableSource; import org.apache.flink.connectors.kudu.table.function.lookup.KuduLookupOptions; import org.apache.flink.connectors.kudu.table.utils.KuduTableUtils; import org.apache.flink.table.api.TableSchema; diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/catalog/KuduCatalogFactory.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/catalog/KuduCatalogFactory.java index 704d31c..8ad9350 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/catalog/KuduCatalogFactory.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/catalog/KuduCatalogFactory.java @@ -15,12 +15,10 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.flink.connectors.kudu.table.dynamic.catalog; import org.apache.flink.annotation.Internal; import org.apache.flink.configuration.ConfigOption; -import org.apache.flink.connectors.kudu.table.KuduCatalog; import org.apache.flink.table.catalog.Catalog; import org.apache.flink.table.factories.CatalogFactory; import org.apache.flink.table.factories.FactoryUtil; @@ -70,5 +68,4 @@ public class KuduCatalogFactory implements CatalogFactory { helper.getOptions().get(KUDU_MASTERS)); } - } diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/AbstractKuduLookupFunction.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/AbstractKuduLookupFunction.java index 60ca7ce..5cb83d0 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/AbstractKuduLookupFunction.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/AbstractKuduLookupFunction.java @@ -15,7 +15,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.flink.connectors.kudu.table.function.lookup; import org.apache.commons.collections.CollectionUtils; diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/KuduLookupOptions.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/KuduLookupOptions.java index 57d408b..5ff3734 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/KuduLookupOptions.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/KuduLookupOptions.java @@ -15,8 +15,8 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.flink.connectors.kudu.table.function.lookup; + /** * Options for the Kudu lookup. */ diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/KuduRowDataLookupFunction.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/KuduRowDataLookupFunction.java index c87d5f1..0f400aa 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/KuduRowDataLookupFunction.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/function/lookup/KuduRowDataLookupFunction.java @@ -15,7 +15,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.flink.connectors.kudu.table.function.lookup; import org.apache.flink.connectors.kudu.connector.KuduTableInfo; diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/utils/KuduTableUtils.java b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/utils/KuduTableUtils.java index 1d97462..1d5be62 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/utils/KuduTableUtils.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/utils/KuduTableUtils.java @@ -14,17 +14,14 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.flink.connectors.kudu.table.utils; -import org.apache.commons.lang3.ArrayUtils; -import org.apache.commons.lang3.StringUtils; import org.apache.flink.api.java.tuple.Tuple2; import org.apache.flink.connectors.kudu.connector.ColumnSchemasFactory; import org.apache.flink.connectors.kudu.connector.CreateTableOptionsFactory; import org.apache.flink.connectors.kudu.connector.KuduFilterInfo; import org.apache.flink.connectors.kudu.connector.KuduTableInfo; -import org.apache.flink.connectors.kudu.table.KuduTableFactory; +import org.apache.flink.shaded.guava30.com.google.common.collect.Lists; import org.apache.flink.table.api.TableSchema; import org.apache.flink.table.expressions.CallExpression; import org.apache.flink.table.expressions.Expression; @@ -36,36 +33,27 @@ import org.apache.flink.table.types.DataType; import org.apache.flink.table.types.logical.DecimalType; import org.apache.flink.table.types.logical.TimestampType; import org.apache.flink.table.utils.TableSchemaUtils; - -import org.apache.flink.shaded.guava30.com.google.common.collect.Lists; - import org.apache.kudu.ColumnSchema; import org.apache.kudu.ColumnTypeAttributes; import org.apache.kudu.Schema; import org.apache.kudu.client.CreateTableOptions; -import org.apache.kudu.client.PartialRow; -import org.apache.kudu.client.RangePartitionBound; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import javax.annotation.Nullable; -import java.math.BigDecimal; -import java.nio.charset.Charset; import java.sql.Timestamp; import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; -import java.util.HashSet; import java.util.List; import java.util.Map; import java.util.Optional; -import java.util.Set; import java.util.stream.Collectors; -import static org.apache.flink.connectors.kudu.table.dynamic.KuduDynamicTableSourceSinkFactory.KUDU_PRIMARY_KEY_COLS; import static org.apache.flink.connectors.kudu.table.dynamic.KuduDynamicTableSourceSinkFactory.KUDU_HASH_COLS; -import static org.apache.flink.connectors.kudu.table.dynamic.KuduDynamicTableSourceSinkFactory.KUDU_REPLICAS; import static org.apache.flink.connectors.kudu.table.dynamic.KuduDynamicTableSourceSinkFactory.KUDU_HASH_PARTITION_NUMS; +import static org.apache.flink.connectors.kudu.table.dynamic.KuduDynamicTableSourceSinkFactory.KUDU_PRIMARY_KEY_COLS; +import static org.apache.flink.connectors.kudu.table.dynamic.KuduDynamicTableSourceSinkFactory.KUDU_REPLICAS; public class KuduTableUtils { @@ -89,7 +77,8 @@ public class KuduTableUtils { ColumnSchemasFactory schemasFactory = () -> toKuduConnectorColumns(columns, keyColumns); int replicas = Optional.ofNullable(props.get(KUDU_REPLICAS.key())).map(Integer::parseInt).orElse(1); // if hash partitions nums not exists,default 3; - int hashPartitionNums = Optional.ofNullable(props.get(KUDU_HASH_PARTITION_NUMS.key())).map(Integer::parseInt).orElse(3); + int hashPartitionNums = + Optional.ofNullable(props.get(KUDU_HASH_PARTITION_NUMS.key())).map(Integer::parseInt).orElse(3); CreateTableOptionsFactory optionsFactory = () -> new CreateTableOptions() .setNumReplicas(replicas) .addHashPartitions(getHashColumns(props), hashPartitionNums); @@ -101,7 +90,8 @@ public class KuduTableUtils { return tableInfo; } - public static List<ColumnSchema> toKuduConnectorColumns(List<Tuple2<String, DataType>> columns, Collection<String> keyColumns) { + public static List<ColumnSchema> toKuduConnectorColumns(List<Tuple2<String, DataType>> columns, + Collection<String> keyColumns) { return columns.stream() .map(t -> { ColumnSchema.ColumnSchemaBuilder builder = new ColumnSchema @@ -132,7 +122,9 @@ public class KuduTableUtils { } public static List<String> getPrimaryKeyColumns(Map<String, String> tableProperties, TableSchema tableSchema) { - return tableProperties.containsKey(KUDU_PRIMARY_KEY_COLS.key()) ? Arrays.asList(tableProperties.get(KUDU_PRIMARY_KEY_COLS.key()).split(",")) : tableSchema.getPrimaryKey().get().getColumns(); + return tableProperties.containsKey(KUDU_PRIMARY_KEY_COLS.key()) ? + Arrays.asList(tableProperties.get(KUDU_PRIMARY_KEY_COLS.key()).split(",")) : + tableSchema.getPrimaryKey().get().getColumns(); } public static List<String> getHashColumns(Map<String, String> tableProperties) { diff --git a/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/KuduTableSourceITCase.java b/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/KuduTableSourceITCase.java index a8d3674..d3d4a63 100644 --- a/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/KuduTableSourceITCase.java +++ b/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/KuduTableSourceITCase.java @@ -18,12 +18,9 @@ package org.apache.flink.connectors.kudu.table; import org.apache.flink.connectors.kudu.connector.KuduTableInfo; import org.apache.flink.connectors.kudu.connector.KuduTestBase; -import org.apache.flink.table.api.EnvironmentSettings; -import org.apache.flink.table.api.StatementSet; import org.apache.flink.table.api.TableEnvironment; import org.apache.flink.types.Row; import org.apache.flink.util.CloseableIterator; -import org.junit.Ignore; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; diff --git a/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicSinkTest.java b/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicSinkTest.java index a5fc007..80f60cf 100644 --- a/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicSinkTest.java +++ b/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicSinkTest.java @@ -23,17 +23,10 @@ import org.apache.flink.table.api.TableEnvironment; import org.apache.flink.table.api.bridge.java.StreamTableEnvironment; import org.apache.flink.types.Row; import org.apache.flink.util.CloseableIterator; -import org.apache.flink.util.CollectionUtil; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -import java.util.Iterator; -import java.util.List; -import java.util.stream.Collectors; -import java.util.stream.Stream; - -import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; /** @@ -60,7 +53,7 @@ public class KuduDynamicSinkTest extends KuduTestBase { @Test public void testKuduSink() throws Exception { - String createSql="CREATE TABLE " + String createSql = "CREATE TABLE " + INPUT_TABLE + "(" + "id int," @@ -84,7 +77,8 @@ public class KuduDynamicSinkTest extends KuduTestBase { + ")"; tEnv.executeSql(createSql); tEnv.executeSql("insert into " + INPUT_TABLE + " values(1006,'test title','test author',10.1,10)"); - CloseableIterator<Row> collected = tEnv.executeSql("select * from " + INPUT_TABLE + " where id =1006").collect(); + CloseableIterator<Row> collected = + tEnv.executeSql("select * from " + INPUT_TABLE + " where id =1006").collect(); assertNotNull(collected); } } diff --git a/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicSourceTest.java b/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicSourceTest.java index 1504c7e..2cab282 100644 --- a/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicSourceTest.java +++ b/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicSourceTest.java @@ -39,7 +39,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull; * Unit Tests for {@link KuduDynamicTableSource}. */ public class KuduDynamicSourceTest extends KuduTestBase { - public final static String INPUT_TABLE = "books"; + public static final String INPUT_TABLE = "books"; public static StreamExecutionEnvironment env; public static TableEnvironment tEnv; diff --git a/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduRowDataLookupFunctionTest.java b/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduRowDataLookupFunctionTest.java index 14f5f52..bc3d51a 100644 --- a/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduRowDataLookupFunctionTest.java +++ b/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/dynamic/KuduRowDataLookupFunctionTest.java @@ -38,7 +38,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull; * Unit Tests for {@link KuduRowDataLookupFunction}. */ public class KuduRowDataLookupFunctionTest extends KuduTestBase { - public final static String INPUT_TABLE = "books"; + public static final String INPUT_TABLE = "books"; public static KuduTableInfo tableInfo; @BeforeEach diff --git a/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/writer/RowDataUpsertOperationMapperTest.java b/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/writer/RowDataUpsertOperationMapperTest.java index 1037d41..dec125d 100644 --- a/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/writer/RowDataUpsertOperationMapperTest.java +++ b/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/writer/RowDataUpsertOperationMapperTest.java @@ -17,32 +17,21 @@ package org.apache.flink.connectors.kudu.writer; import org.apache.flink.connectors.kudu.connector.KuduTestBase; -import org.apache.flink.connectors.kudu.connector.writer.AbstractSingleOperationMapper; import org.apache.flink.connectors.kudu.connector.writer.RowDataUpsertOperationMapper; -import org.apache.flink.connectors.kudu.connector.writer.RowOperationMapper; -import org.apache.flink.connectors.kudu.table.dynamic.KuduDynamicTableSource; -import org.apache.flink.connectors.kudu.table.utils.KuduTableUtils; -import org.apache.flink.table.data.DecimalData; import org.apache.flink.table.data.RowData; -import org.apache.flink.table.data.StringData; -import org.apache.flink.table.types.logical.DecimalType; -import org.apache.flink.table.types.logical.LogicalType; -import org.apache.flink.types.Row; import org.apache.kudu.client.Operation; import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.Test; import java.util.List; -import static org.apache.flink.table.types.logical.utils.LogicalTypeChecks.getPrecision; import static org.junit.Assert.assertEquals; -import static org.junit.jupiter.api.Assertions.*; import static org.mockito.Mockito.verify; /** * Unit Tests for {@link RowDataUpsertOperationMapper}. */ -public class RowDataUpsertOperationMapperTest extends AbstractOperationTest { +public class RowDataUpsertOperationMapperTest extends AbstractOperationTest { @Test void testGetField() {
