bchapuis commented on code in PR #858:
URL:
https://github.com/apache/incubator-baremaps/pull/858#discussion_r1621913937
##########
baremaps-geoparquet/src/test/java/org/apache/baremaps/geoparquet/GeoParquetReaderTest.java:
##########
@@ -17,26 +17,51 @@
package org.apache.baremaps.geoparquet;
+import static org.junit.jupiter.api.Assertions.*;
+
import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
+import java.util.concurrent.atomic.AtomicInteger;
import org.apache.baremaps.testing.TestFiles;
+import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
class GeoParquetReaderTest {
@Test
void read() throws IOException, URISyntaxException {
- // URI geoParquet = new
- //
URI("s3a://overturemaps-us-west-2/release/2024-03-12-alpha.0/theme=admins/type=locality_area/*.parquet");
URI geoParquet = TestFiles.GEOPARQUET.toUri();
+ final boolean isPrintingContent = true;
Review Comment:
I usually don't print content in the unit tests. I believe this was a left
over... I don't mind merging the PR, but I think we should remove this in the
future.
##########
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/hadoop/GeoParquetGroupWriter.java:
##########
@@ -17,46 +17,13 @@
package org.apache.baremaps.geoparquet.hadoop;
-import org.apache.baremaps.geoparquet.data.GeoParquetGroupImpl;
+import org.apache.baremaps.geoparquet.common.GroupWriter;
import org.apache.parquet.io.api.RecordConsumer;
import org.apache.parquet.schema.GroupType;
-import org.apache.parquet.schema.Type;
-public class GeoParquetGroupWriter {
-
- private final RecordConsumer recordConsumer;
- private final GroupType schema;
+public class GeoParquetGroupWriter extends GroupWriter {
Review Comment:
Yes, we can do this later in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
