[ https://issues.apache.org/jira/browse/BEAM-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15844088#comment-15844088 ]
ASF GitHub Bot commented on BEAM-1334: -------------------------------------- GitHub user aviemzur opened a pull request: https://github.com/apache/beam/pull/1865 [BEAM-1334] Split UsesMetrics category and tests into UsesCommittedMetrics and UsesAttemptedMetrics Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/aviemzur/incubator-beam split-metrics-test-category Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/1865.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1865 ---- commit e04bff97b9810ffcd76e467a0a3c05a7c79720ef Author: Aviem Zur <aviem...@gmail.com> Date: 2017-01-28T15:08:58Z [BEAM-1334] Split UsesMetrics category and tests into UsesCommittedMetrics and UsesAttemptedMetrics ---- > Split UsesMetrics category and tests into UsesCommittedMetrics and > UsesAttemptedMetrics > --------------------------------------------------------------------------------------- > > Key: BEAM-1334 > URL: https://issues.apache.org/jira/browse/BEAM-1334 > Project: Beam > Issue Type: Task > Components: sdk-java-core > Reporter: Aviem Zur > Assignee: Ben Chambers > Priority: Minor > > Some runners may not be able to implement both {{committed}} and > {{attempted}} results in {{MetricResult}}. > Seeing this, split the current {{RunnableOnService}} test > {{org.apache.beam.sdk.metrics.MetricsTest#metricsReportToQuery}} into two > tests, which test attempted and committed results separately with categories > {{UsesCommittedMetrics}} and {{UsesAttemptedMetrics}} instead of the current > category {{UsesMetrics}}. > Discussion that led to this can be seen in the this > [PR|https://github.com/apache/beam/pull/1750#issuecomment-275412984] -- This message was sent by Atlassian JIRA (v6.3.4#6332)