[jira] (BEAM-1278) Use checkstyle on everything

[Benson Margulies (JIRA)]

Title: Message Title

Benson Margulies commented on BEAM-1278   Re: Use checkstyle on everything There is a dilemma here which surfaced in a discussion I had with Davor Bonaci yesterday. The PR enables checkstyle everywhere by using a file system path for the rules instead of the classpath. It uses a Maven plugin to acquire the 'project root directory' from the subdirectories. (I don't really know how that plugin manages to do the right thing if you cd into some subdir and run it; does it just chase relativePath until it hits a parent which is somewhere else?) In any case, the effect of this is to make it impossible to build a submodule in isolation by unpacking its source jar. We're not happy to break that. There is an alternative: use the classpath when we can, and use the file path when we cannot. The top-level pom, and the 'sdks' pom, and the 'sdks/java' pom, would use the file path. The poms that currently use the classpath to enable checkstyle would override the configuration to use the classpath. That forces some duplication of the configuration; given the current directory structure, I don't know a way to avoid repeating this in several jars. Well, actually, I do, but it would be rather structurally violent: the top-level pom would need to have two children: buildtools and 'everything else'. Before I either go rework the patch to have this checkstyle repetition, or we close this down as a cure worse than a disease, I want to just point back to JB's remark: a common practice is to separately release a maven project containing these materials. We don't need to have a separate git repo; we can just have a directory which has an independent pom with the necessary maven-release-plugin configuration. The claim here is that the checkstyle rules do not change very often, so having to release the buildtools component whenever you change them is not so awful. Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)