GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/1895

    [BEAM-65] ProcessFn: create invoker in setup()

    This makes more sense than creating it in constructor, since
    the fn can be serialized (and will be - by Dataflow runner).
    
    However, since direct runner creates the fn explicitly during
    evaluation, we need to also call setup() explicitly.
    
    R: @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam sdf-setup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1895.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1895
    
----
commit 5546ad68fd18315a251d059b7c8c512640172d24
Author: Eugene Kirpichov <kirpic...@google.com>
Date:   2017-02-02T00:07:44Z

    [BEAM-65] ProcessFn: create invoker in setup()
    
    This makes more sense than creating it in constructor, since
    the fn can be serialized (and will be - by Dataflow runner).
    
    However, since direct runner creates the fn explicitly during
    evaluation, we need to also call setup() explicitly.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to