[ 
https://issues.apache.org/jira/browse/BEAM-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853309#comment-15853309
 ] 

ASF GitHub Bot commented on BEAM-1395:
--------------------------------------

GitHub user amitsela opened a pull request:

    https://github.com/apache/beam/pull/1922

    [BEAM-1395] SparkGroupAlsoByWindowFn not sorting grouped elements by 
timestamp

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amitsela/beam BEAM-1395

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1922.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1922
    
----
commit d2b1c678a45dd740c4ec4dbdf508564dd78e3abe
Author: Sela <ans...@paypal.com>
Date:   2017-02-05T18:17:24Z

    [BEAM-1395] SparkGroupAlsoByWindowFn now sorts grouped elements by 
timestamp.

----


> SparkGroupAlsoByWindowFn not sorting grouped elements by timestamp
> ------------------------------------------------------------------
>
>                 Key: BEAM-1395
>                 URL: https://issues.apache.org/jira/browse/BEAM-1395
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Amit Sela
>            Assignee: Amit Sela
>
> SparkGroupAlsoByWindowFn relies on the grouped elements (pre key) to be 
> sorted by their timestamp, which is not the case, and so could cause: 
> {code}
> IllegalStateException: Cannot move input watermark time backwards
> {code}
> We should sort the values first, just like with {{Combine}} implementations: 
> https://github.com/apache/beam/blob/master/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkKeyedCombineFn.java#L73



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to