GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2039
[BEAM-646] Use Surgery in the Dataflow Runner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Couple of cleanups and underlying PRs still have to be submitted prior to
actual review.
I do want to use this PR to run some RunnableOnService Tests, though.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam dataflow_runner_surgery
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2039.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2039
----
commit 02f01effdcf1a9a01dd1f0c6c94a3d025d16c064
Author: Thomas Groh <tg...@google.com>
Date: 2017-02-16T22:44:16Z
Move Batch View Overrides out of DataflowRunner
Although these are runner specific, they don't need to be in the runner
shim class.
commit e344eaf70500c5594818b36df3047147ae0486d1
Author: Thomas Groh <tg...@google.com>
Date: 2017-02-16T22:58:52Z
Move Streaming View Overrides out of the DataflowRunner
These overrides are implementation details of the runner and
runner-specific, but need not be within the Runner shim.
commit 71257024a18ccee8b881ae15be12145efefccd15
Author: Thomas Groh <tg...@google.com>
Date: 2017-02-17T03:14:23Z
Add a Base OverrideFactory class for 1-to-1 overrides
These overrides are relatively common, and this reduces the
reimplementation of mapping singletons and casting them.
commit 46d6b1e12c9138516cd111b853bfb06fe545deab
Author: Thomas Groh <tg...@google.com>
Date: 2017-02-16T21:57:21Z
Make Dataflow perform Surgery
It's not Rocket Surgery, guys.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
