[
https://issues.apache.org/jira/browse/BEAM-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877451#comment-15877451
]
ASF GitHub Bot commented on BEAM-1465:
--------------------------------------
GitHub user aviemzur opened a pull request:
https://github.com/apache/beam/pull/2067
[BEAM-1465] No natural place to flush/close resources in FileBasedWriter
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aviemzur/beam
filebasedwriter-finishwrite-method
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2067.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2067
----
commit ca63cff4045cb60ed377b2727f01a457579d057c
Author: Aviem Zur <aviem...@gmail.com>
Date: 2017-02-22T04:26:38Z
[BEAM-1465] No natural place to flush/close resources in FileBasedWriter
----
> No natural place to flush/close resources in FileBasedWriter
> ------------------------------------------------------------
>
> Key: BEAM-1465
> URL: https://issues.apache.org/jira/browse/BEAM-1465
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Aviem Zur
> Assignee: Aviem Zur
>
> {{FileBasedWriter}} API does not have a natural place to flush/close
> resources opened by the writer.
> For example, if you create an {{OutputStream}} in your {{Writer}} using the
> {{FileBasedSink}}'s channel and this {{OutputStream}} buffers outputs, there
> is no natural place to call its {{flush()}} method.
> Maybe something like {{finishWrite()}} to match the existing
> {{prepareWrite(WritableByteChannel channel)}} can work.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
