[ https://issues.apache.org/jira/browse/BEAM-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903562#comment-15903562 ]
ASF GitHub Bot commented on BEAM-1401: -------------------------------------- GitHub user kennknowles opened a pull request: https://github.com/apache/beam/pull/2212 [BEAM-1401] Add windowing support to FileBasedSink Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- Reuven is on vacation so this takes over #1926 with rebase and squash. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kennknowles/beam windowed-io Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2212.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2212 ---- commit d9649085197a47df744cf9d748a47d429e47aa42 Author: Reuven Lax <re...@google.com> Date: 2017-03-09T17:45:35Z Add windowing support to FileBasedSink ---- > Sinks in Beam should supported windowed unbounded PCollections > -------------------------------------------------------------- > > Key: BEAM-1401 > URL: https://issues.apache.org/jira/browse/BEAM-1401 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Reuven Lax > Assignee: Kenneth Knowles > -- This message was sent by Atlassian JIRA (v6.3.15#6346)