Aviem Zur created BEAM-1720:
-------------------------------

             Summary: Consider minimization on shaded jars
                 Key: BEAM-1720
                 URL: https://issues.apache.org/jira/browse/BEAM-1720
             Project: Beam
          Issue Type: Improvement
          Components: build-system
            Reporter: Aviem Zur
            Assignee: Aviem Zur


Some of our modules shade and relocate Guava as part of their build, this adds 
a considerable amount to their file size, even though they do not use every 
single class in Guava's jar.
maven shade-plugin solves this by minimization which only shades classes which 
are in use in the module into the jar.

There are a few issues with configuring minimzation for our shaded modules 
currently:

1. There is a bug in shade-plugin where if minimization is declared on a 
project with pom packaging it fails. I have created a 
[ticket|https://issues.apache.org/jira/browse/MSHADE-253] and 
[PR|https://github.com/apache/maven-plugins/pull/107] with a fix for this but 
could take a while before it is available to us.
2. Minimization on all of our modules adds a significant amount of build time, 
which we wish to avoid. (Up from 02:30 mins for a build of the entire project 
(skipping tests) on a Macbook pro laptop to over 5 mins)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to