[ 
https://issues.apache.org/jira/browse/BEAM-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933746#comment-15933746
 ] 

Ted Yu edited comment on BEAM-1761 at 3/20/17 11:01 PM:
--------------------------------------------------------

I checked most recent master branch.
AutoValue_HDFSFileSink.java is generated code and HDFSFileSource.java doesn't 
contain the above quoted snippet :-)


was (Author: yuzhih...@gmail.com):
I checked most recent master branch.
AutoValue_HDFSFileSink.java is gone and HDFSFileSource.java doesn't contain the 
above quoted snippet :-)

> Unintended unboxing of potential null pointer in AutoValue_HDFSFileSource
> -------------------------------------------------------------------------
>
>                 Key: BEAM-1761
>                 URL: https://issues.apache.org/jira/browse/BEAM-1761
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: Not applicable
>
>
> {code}
>       if (validateSource == null) {
>         missing += " validateSource";
>       }
> ...
>       return new AutoValue_HDFSFileSource<T, K, V>(
>           this.filepattern,
>           this.formatClass,
>           this.coder,
>           this.inputConverter,
>           this.serializableConfiguration,
>           this.serializableSplit,
>           this.username,
>           this.validateSource);
> {code}
> If validateSource is null, it would be unboxed in call to ctor of 
> AutoValue_HDFSFileSource



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to