[
https://issues.apache.org/jira/browse/BEAM-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941130#comment-15941130
]
ASF GitHub Bot commented on BEAM-1655:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2321
[BEAM-1655] Enable nackAll on all PubsubCheckpoints
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This method should not fail if the checkpoint has not been decoded.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam unbounded_read_encode_decode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2321.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2321
----
commit 09610cbbbcff2795edd8f5f175a2ba73e0496b17
Author: Thomas Groh <tg...@google.com>
Date: 2017-03-24T21:01:51Z
Enable nackAll on all PubsubCheckpoints
This method should not fail if the checkpoint has not been decoded.
----
> Evaluate the PubsubUnboundedSource
> ----------------------------------
>
> Key: BEAM-1655
> URL: https://issues.apache.org/jira/browse/BEAM-1655
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions
> Reporter: Ben Chambers
> Assignee: Thomas Groh
>
> This source includes a lot of assumptions & assertions that may cause
> problems on runners that implement UnboundedSources differently. For example:
> 1. It requires that finalizeCheckpoint is called at most once.
> 2. It requires that the checkpoint be finalized within the pubsub timeout, or
> the messages will be redelivered.
> ... (possibly other assumptions) ...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
