[ https://issues.apache.org/jira/browse/BEAM-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941174#comment-15941174 ]
ASF GitHub Bot commented on BEAM-1801: -------------------------------------- GitHub user pabloem opened a pull request: https://github.com/apache/beam/pull/2322 [BEAM-1801] Fix Python Dataflow default job name Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- r: @aaltay You can merge this pull request into a Git repository by running: $ git pull https://github.com/pabloem/incubator-beam fix-py-def-jobname Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2322.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2322 ---- commit 8a37324bc240336f43135523107dc47a86ddbb66 Author: Pablo <pabl...@google.com> Date: 2017-03-24T21:31:33Z Fix Python Dataflow default job name ---- > default_job_name can generate names not accepted by DataFlow > ------------------------------------------------------------ > > Key: BEAM-1801 > URL: https://issues.apache.org/jira/browse/BEAM-1801 > Project: Beam > Issue Type: Bug > Components: sdk-py > Reporter: Dennis Docter > Assignee: Pablo Estrada > Priority: Trivial > > The default job name generated by: > https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py#L288 > is partially derived from the os username of the executing user. These may > contain characters not accepted by Dataflow, resulting in errors like: > apache_beam.runners.dataflow.dataflow_runner.DataflowRuntimeException: > Dataflow pipeline failed. State: FAILED, Error: > (a1b878f3562c0e6d): Error processing pipeline. Causes: (a1b878f3562c04ae): > Prefix for cluster 'beamapp-dennis.docter-032-03231324-1edc-harness' should > match '[a-z]([-a-z0-9]{0,61}[a-z0-9])?'. This probably means the joblabel is > invalid. > To solve this issue, sanitise the username to only container alphanumeric > characters and dashes. > Also there seems to be no length restriction and dataflow imposes a 63 > character length limit in the above case. Limiting on length substantially > shorter than that to allow for postfixes (like -harness in this case) may be > wise. -- This message was sent by Atlassian JIRA (v6.3.15#6346)