[ https://issues.apache.org/jira/browse/BEAM-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943902#comment-15943902 ]
ASF GitHub Bot commented on BEAM-1818: -------------------------------------- GitHub user tgroh opened a pull request: https://github.com/apache/beam/pull/2338 [BEAM-1818] Add PTransform#getAdditionalInputs() Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This permits all PTransforms to expose any input PValues they recieve via a side channel. This lets the Pipeline include those inputs as input to the PTransform node even when the actual generic PTransform types do not include those inputs (e.g. as a Side Input to a ParDo, which is not represented in the input PCollection type). Implement getAdditionalInputs in ParDo and Combine. getAdditionalInputs is currently unused. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/beam ptransform_additional_outputs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2338.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2338 ---- commit d4314198869436a2923039938460e62eb9879133 Author: Thomas Groh <tg...@google.com> Date: 2017-03-22T20:48:57Z Add PTransform#getAdditionalInputs() This permits all PTransforms to expose any input PValues they recieve via a side channel. This lets the Pipeline include those inputs as input to the PTransform node even when the actual generic PTransform types do not include those inputs (e.g. as a Side Input to a ParDo, which is not represented in the input PCollection type). Implement getAdditionalInputs in ParDo and Combine. getAdditionalInputs is currently unused. ---- > Expose side-channel inputs in PTransform > ---------------------------------------- > > Key: BEAM-1818 > URL: https://issues.apache.org/jira/browse/BEAM-1818 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Thomas Groh > Assignee: Thomas Groh > > This enables all PTransforms to consume inputs without using those inputs > provided in the PInput they are applied to, the same way ParDo and Combine do > with {{getSideInputs}} > See > https://docs.google.com/document/d/1GlcfuMLCTnvleZUWUN4ZAhK_ybXJwDb8ms593DFuA5U/edit -- This message was sent by Atlassian JIRA (v6.3.15#6346)