[ 
https://issues.apache.org/jira/browse/BEAM-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947985#comment-15947985
 ] 

ASF GitHub Bot commented on BEAM-1830:
--------------------------------------

GitHub user rangadi opened a pull request:

    https://github.com/apache/beam/pull/2364

    [BEAM-1830] KafkaIO : Add withTopic() api that takes single topic.

    Overwhelming uses of KafkaIO consume just one topic. It would be nice to 
have `withTopic(topic)` rather than always requiring a list. 
    
    In addition, I am fixing a small bug I noticed while using 
`KafkaIO.write().values()`.  Remove need for setting key coder for Writer while 
writing values only. If we didn't specifiy the key coder, validation succeeded 
but it failed a check while instantiating Kafka producer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rangadi/incubator-beam with_topic

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2364
    
----
commit d958c7bdb14ea42f80b955a94fd9d4f6b1b870fc
Author: Raghu Angadi <rang...@google.com>
Date:   2017-03-29T15:17:25Z

    KafkaIO : Add withTopic() api that takes single topic.
    
    Remove need for setting key coder for Writer while writing
    values only. If we didn't specifiy the key coder, validation
    succeeded but it failed a check while instantiating Kafka producer.

----


> add 'withTopic()' api to KafkaIO Reader
> ---------------------------------------
>
>                 Key: BEAM-1830
>                 URL: https://issues.apache.org/jira/browse/BEAM-1830
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-extensions
>    Affects Versions: 0.6.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>             Fix For: First stable release
>
>
> Most of instances of KafkaIO readers consume just one topic. The existing 
> method {{withTopics(List<String> topics)}} forces the users to make a list 
> containing single topic.
> It would be simpler to add {{withTopic(String topic)}} method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to