[ https://issues.apache.org/jira/browse/BEAM-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955486#comment-15955486 ]
ASF GitHub Bot commented on BEAM-846: ------------------------------------- GitHub user tgroh opened a pull request: https://github.com/apache/beam/pull/2426 [BEAM-846] Remove getSideInputWindow Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- Callers should instead get the Default WindowMappingFn if no explicit WindowMappingFn is available. Migrate all existing callers within the SDK and runners. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/beam remove_get_side_input_window Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2426.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2426 ---- commit 7bb932c94b55bc640f539967a7273f8cdf15dd05 Author: Thomas Groh <tg...@google.com> Date: 2017-04-04T17:38:36Z Remove getSideInputWindow Callers should instead get the Default WindowMappingFn if no explicit WindowMappingFn is available. Migrate all existing callers within the SDK and runners. ---- > Decouple side input window mapping from WindowFn > ------------------------------------------------ > > Key: BEAM-846 > URL: https://issues.apache.org/jira/browse/BEAM-846 > Project: Beam > Issue Type: New Feature > Components: beam-model-runner-api, sdk-java-core > Reporter: Robert Bradshaw > Assignee: Thomas Groh > Labels: backward-incompatible > Fix For: First stable release > > > Currently the main WindowFn provides as getSideInputWindow method. Instead, > this mapping should be specified per-side-input (thought the default mapping > would remain the same). -- This message was sent by Atlassian JIRA (v6.3.15#6346)