[ 
https://issues.apache.org/jira/browse/BEAM-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958142#comment-15958142
 ] 

ASF GitHub Bot commented on BEAM-1880:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2428


> DataflowPipelineJob.cancel() should behave gracefully if called concurrent 
> with job termination
> -----------------------------------------------------------------------------------------------
>
>                 Key: BEAM-1880
>                 URL: https://issues.apache.org/jira/browse/BEAM-1880
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>
> In Dataflow runner, we use job state to avoid canceling finished jobs, or to 
> notice when we tried to cancel a finished job. However, the job state is not 
> authoritative about whether the job is done, and cancel will throw an error 
> if they happen to be near each other in time. This causes flaky tests and bad 
> developer experience.
> Future changes to Dataflow service will make this much more likely to happen.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to