[ https://issues.apache.org/jira/browse/BEAM-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Kirpichov reassigned BEAM-1414: -------------------------------------- Assignee: (was: Davor Bonaci) > CountingInput should comply with PTransform style guide > ------------------------------------------------------- > > Key: BEAM-1414 > URL: https://issues.apache.org/jira/browse/BEAM-1414 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Eugene Kirpichov > Labels: backward-incompatible, starter > Fix For: First stable release > > > Suggested changes: > - Rename the whole class and its inner transforms to sound more verb-like, > e.g.: GenerateRange.Bounded/Unbounded (as opposed to current > CountingInput.BoundedCountingInput) > - Provide a more unified API between bounded and unbounded cases: > GenerateRange.from(100) should return a GenerateRange.Unbounded; > GenerateRange.from(100).to(200) should return a GenerateRange.Bounded. They > both should accept a timestampFn. The unbounded one _should not_ have a > withMaxNumRecords builder - that's redundant with specifying the range. > - (optional) Use AutoValue -- This message was sent by Atlassian JIRA (v6.3.15#6346)